From: David Miller <davem@davemloft.net>
To: ahabdels@gmail.com
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrea.mayer@uniroma2.it
Subject: Re: [PATCH] seg6: using DSCP of inner IPv4 packets
Date: Wed, 05 Aug 2020 17:40:49 -0700 (PDT) [thread overview]
Message-ID: <20200805.174049.1470539179902962793.davem@davemloft.net> (raw)
In-Reply-To: <20200804074030.1147-1-ahabdels@gmail.com>
From: Ahmed Abdelsalam <ahabdels@gmail.com>
Date: Tue, 4 Aug 2020 07:40:30 +0000
> This patch allows copying the DSCP from inner IPv4 header to the
> outer IPv6 header, when doing SRv6 Encapsulation.
>
> This allows forwarding packet across the SRv6 fabric based on their
> original traffic class.
>
> Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
You have changed the hop limit behavior here and that neither seems
intentional nor correct.
When encapsulating ipv6 inside of ipv6 the inner hop limit should be
inherited. You should only use the DST hop limit when encapsulating
ipv4.
And that's what the existing code did.
next prev parent reply other threads:[~2020-08-06 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 7:40 [PATCH] seg6: using DSCP of inner IPv4 packets Ahmed Abdelsalam
2020-08-04 20:08 ` David Miller
2020-08-06 0:40 ` David Miller [this message]
2020-08-06 6:43 ` Ahmed Abdelsalam
2020-08-08 0:43 ` David Miller
2020-08-15 9:47 ` Ahmed Abdelsalam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805.174049.1470539179902962793.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ahabdels@gmail.com \
--cc=andrea.mayer@uniroma2.it \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).