linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: kernel test robot <lkp@intel.com>,
	linux-kernel@vger.kernel.org, Paul Burton <paul.burton@mips.com>,
	linux-mips@vger.kernel.org
Subject: Re: arch/mips/include/asm/mach-ip27/topology.h:19:7: error: implicit declaration of function 'hub_data'
Date: Wed, 5 Aug 2020 10:37:20 +0200	[thread overview]
Message-ID: <20200805083720.GA7297@alpha.franken.de> (raw)
In-Reply-To: <20200803194910.GC72435@linux.ibm.com>

On Mon, Aug 03, 2020 at 10:49:10PM +0300, Mike Rapoport wrote:
> On Tue, Aug 04, 2020 at 01:39:14AM +0800, kernel test robot wrote:
> [...]
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    In file included from arch/mips/include/asm/topology.h:11,
> >                     from include/linux/topology.h:36,
> >                     from include/linux/gfp.h:9,
> >                     from include/linux/slab.h:15,
> >                     from include/linux/crypto.h:19,
> >                     from include/crypto/hash.h:11,
> >                     from include/linux/uio.h:10,
> >                     from include/linux/socket.h:8,
> >                     from include/linux/compat.h:15,
> >                     from arch/mips/kernel/asm-offsets.c:12:
> >    arch/mips/include/asm/mach-ip27/topology.h:25:39: error: 'MAX_COMPACT_NODES' undeclared here (not in a function)
> >       25 | extern unsigned char __node_distances[MAX_COMPACT_NODES][MAX_COMPACT_NODES];
> >          |                                       ^~~~~~~~~~~~~~~~~
> >    include/linux/topology.h: In function 'numa_node_id':
> > >> arch/mips/include/asm/mach-ip27/topology.h:16:27: error: implicit declaration of function 'cputonasid' [-Werror=implicit-function-declaration]
> >       16 | #define cpu_to_node(cpu) (cputonasid(cpu))
> >          |                           ^~~~~~~~~~
> 
> This happens when randconfig disables NUMA and has SGI_IP27 enabled.
> Before switch from discontigmem to sparsemem, there always was
> CONFIG_NEED_MULTIPLE_NODES=y because it was selected by DISCONTIGMEM.
> Without DISCONTIGMEM it is possible to have SPARSEMEM without NUMA for
> SGI_IP27 and as many things there rely on custom node definition, the
> build breaks.
> 
> I don't remember small Origin or Onyx systems so I think it would be
> reasonable to make SGI_IP27 to select NUMA.

IMHO there are right now too many places in IP27 code, which assumes NUMA
enabled, so your patch makes sense. And if someone wants to get it
supported without NUMA enabled, I'm taking that patch as well.

> If the below patch makes sense I'll resend it formally.

yes please.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

  parent reply	other threads:[~2020-08-05  8:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 17:39 arch/mips/include/asm/mach-ip27/topology.h:19:7: error: implicit declaration of function 'hub_data' kernel test robot
2020-08-03 19:49 ` Mike Rapoport
2020-08-03 23:58   ` Joshua Kinard
2020-08-04 11:34     ` Jiaxun Yang
2020-08-04 12:37       ` Mike Rapoport
2020-08-04 12:59     ` Mike Rapoport
2020-08-05  8:37   ` Thomas Bogendoerfer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-07-27 15:00 kernel test robot
2020-06-15  6:20 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200805083720.GA7297@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=paul.burton@mips.com \
    --cc=rppt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).