From: Sudeep Holla <sudeep.holla@arm.com>
To: Jason Liu <jason.hui.liu@nxp.com>
Cc: Marc Zyngier <maz@kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"sashal@kernel.org" <sashal@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked
Date: Wed, 5 Aug 2020 09:47:57 +0100 [thread overview]
Message-ID: <20200805084748.GA4818@bogus> (raw)
In-Reply-To: <VI1PR0402MB38243230C51FDB1C3F490853AE4B0@VI1PR0402MB3824.eurprd04.prod.outlook.com>
On Wed, Aug 05, 2020 at 06:31:20AM +0000, Jason Liu wrote:
> >
> > Indeed, the runtime PM ops in that driver looks dodgy. Any calls to mask_irq
> > from drivers or anywhere with irqchip suspended with just blows up the
> > system.
>
> If you look at the chip->irq_mask implementation on different platforms, almost
> all with directly access the register of the irqchip including irqsteer.
> There are fine due to driver will use the common mask_irq API.
>
That still doesn't explain how you can prevent system from blowing up if
chip->irq_mask gets called with irqchip suspended ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-08-05 8:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 8:56 [PATCH 1/1] arm64: kexec: no need to do irq_chip->irq_mask if it already masked Jason Liu
2020-08-04 10:20 ` Sudeep Holla
2020-08-05 6:30 ` Jason Liu
2020-08-04 10:58 ` Marc Zyngier
2020-08-04 11:38 ` Sudeep Holla
2020-08-05 6:31 ` Jason Liu
2020-08-05 8:17 ` Marc Zyngier
2020-08-06 10:05 ` Jason Liu
2020-08-06 12:25 ` Marc Zyngier
2020-08-13 6:03 ` Jason Liu
2020-08-13 10:08 ` Marc Zyngier
2020-08-05 8:47 ` Sudeep Holla [this message]
2020-08-06 10:09 ` Jason Liu
-- strict thread matches above, loose matches on Subject: below --
2020-07-02 9:27 Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805084748.GA4818@bogus \
--to=sudeep.holla@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jason.hui.liu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sashal@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).