From: Christian Brauner <christian.brauner@ubuntu.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] fork cleanup for v5.9
Date: Wed, 5 Aug 2020 17:17:07 +0200 [thread overview]
Message-ID: <20200805151707.boubg3h4vetewxow@wittgenstein> (raw)
In-Reply-To: <20200805083128.GA27209@infradead.org>
On Wed, Aug 05, 2020 at 09:31:28AM +0100, Christoph Hellwig wrote:
> On Tue, Aug 04, 2020 at 01:28:01PM +0200, Christian Brauner wrote:
> > High-level this does two main things:
> > 1. Remove the double export of both do_fork() and _do_fork() where do_fork()
> > used the incosistent legacy clone calling convention. Now we only export
> > _do_fork() which is based on struct kernel_clone_args.
>
> Can we retire the _do_fork name as well please? For one we really don't
> use single underscore prefix in the kernel, and we also try to avoid our
> normal __ prefixes if there is no non-prefixed vesion. Also the name
> feels wrong, as this implements all of clone and not just fork.
> What about kernel_clone to match the name of the args structure?
Yep, sounds good. I actually had a patch for that but it introduced a
lot of jitter into the series because there's quite a few odd places
where _do_fork() is used.
>
> Also none of them actaully is exported (thankfully!).
Ah, sorry that was confusing. What I meant was "exported" in the sense
of visible outside of the file not actually in the "useable from
modules" sense.
Thanks!
Christian
next prev parent reply other threads:[~2020-08-05 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 11:28 [GIT PULL] fork cleanup for v5.9 Christian Brauner
2020-08-04 21:56 ` Linus Torvalds
2020-08-05 15:14 ` Christian Brauner
2020-08-04 22:25 ` pr-tracker-bot
2020-08-05 8:31 ` Christoph Hellwig
2020-08-05 15:17 ` Christian Brauner [this message]
2020-08-05 15:29 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805151707.boubg3h4vetewxow@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).