From: Andrew Lunn <andrew@lunn.ch>
To: Joe Perches <joe@perches.com>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching
Date: Wed, 5 Aug 2020 23:24:56 +0200 [thread overview]
Message-ID: <20200805212456.GC2005851@lunn.ch> (raw)
In-Reply-To: <957f48692a2f0bc4df2d83068073c4822da30eef.camel@perches.com>
On Wed, Aug 05, 2020 at 11:47:38AM -0700, Joe Perches wrote:
> On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote:
> > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote:
> > > On Wed, Aug 5, 2020 at 7:34 AM Russell King <rmk+kernel@armlinux.org.uk> wrote:
> > > > Is this something you're willing to merge directly please?
> > >
> > > Done.
> > >
> > > That said:
> > >
> > > > -K: phylink
> > > > +K: phylink\.h|struct\s+phylink|\.phylink|>phylink_|phylink_(autoneg|clear|connect|create|destroy|disconnect|ethtool|helper|mac|mii|of|set|start|stop|test|validate)
> > >
> > > That's a very awkward pattern. I wonder if there could be better ways
> > > to express this (ie "only apply this pattern to these files" kind of
> > > thing)
> >
> > Yes, it's extremely awkward - I spent much of the morning with perl
> > testing it out on the drivers/ subtree.
>
> There are a lot of phylink_<foo> in the kernel.
> Are those really the only uses you want to watch?
Hi Joe
I think Rusells intention here is to match on MAC drivers which make
use of the phylink API exported to them.
SFF/SFP/SFP+ MODULE SUPPORT
M: Russell King <linux@armlinux.org.uk>
L: netdev@vger.kernel.org
S: Maintained
F: drivers/net/phy/phylink.c
F: drivers/net/phy/sfp*
F: include/linux/phylink.h
F: include/linux/sfp.h
K: phylink
> $ git grep -P -oh 'phylink_\w+'| sort | uniq -c
Try that again, but skip files matched by the F: clauses.
I suspect the matches you get then more closely approximates the K:
Russell is suggesting.
Andrew
next prev parent reply other threads:[~2020-08-05 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 14:34 [PATCH] MAINTAINERS: update phylink/sfp keyword matching Russell King
2020-08-05 18:11 ` Linus Torvalds
2020-08-05 18:22 ` Russell King - ARM Linux admin
2020-08-05 18:47 ` Joe Perches
2020-08-05 21:24 ` Andrew Lunn [this message]
2020-08-05 22:09 ` Russell King - ARM Linux admin
2020-08-05 23:07 ` Joe Perches
2020-08-05 18:54 ` Joe Perches
2020-08-05 22:02 ` Russell King - ARM Linux admin
2020-08-05 22:09 ` Joe Perches
2020-08-05 22:12 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805212456.GC2005851@lunn.ch \
--to=andrew@lunn.ch \
--cc=dvyukov@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).