From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Muchun Song <songmuchun@bytedance.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Chengming Zhou <zhouchengming@bytedance.com>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [External] linux-next: build warning after merge of the ftrace tree
Date: Thu, 6 Aug 2020 02:04:45 +0900 [thread overview]
Message-ID: <20200806020445.649ddaa8b8ec1b91e23508e4@kernel.org> (raw)
In-Reply-To: <20200805111105.081276bb@oasis.local.home>
On Wed, 5 Aug 2020 11:11:05 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 5 Aug 2020 12:53:39 +0800
> Muchun Song <songmuchun@bytedance.com> wrote:
>
> > On Wed, Aug 5, 2020 at 12:21 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > Hi all,
> > >
> > > After merging the ftrace tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > kernel/kprobes.c: In function 'kill_kprobe':
> > > kernel/kprobes.c:1116:33: warning: statement with no effect [-Wunused-value]
> > > 1116 | #define disarm_kprobe_ftrace(p) (-ENODEV)
> > > | ^
> > > kernel/kprobes.c:2154:3: note: in expansion of macro 'disarm_kprobe_ftrace'
> > > 2154 | disarm_kprobe_ftrace(p);
> > > | ^~~~~~~~~~~~~~~~~~~~
> > >
> >
> > Sorry, maybe we should rework the macro of disarm_kprobe_ftrace to an
> > inline function like below.
> >
> > -#define disarm_kprobe_ftrace(p) (-ENODEV)
> > +static inline int disarm_kprobe_ftrace(struct kprobe *p)
> > +{
> > + return -ENODEV
> > +}
> > #endif
>
> Looks like that would work. Care to send a formal patch. Could you also
> change arm_kprobe_ftrace() as well?
Looks good to me too as far as updating it to static inline function.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-08-05 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 4:21 linux-next: build warning after merge of the ftrace tree Stephen Rothwell
2020-08-05 4:53 ` [External] " Muchun Song
2020-08-05 15:11 ` Steven Rostedt
2020-08-05 15:51 ` Muchun Song
2020-08-05 17:04 ` Masami Hiramatsu [this message]
2020-08-05 17:09 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806020445.649ddaa8b8ec1b91e23508e4@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=songmuchun@bytedance.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).