From: Mark Brown <broonie@kernel.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
rafael@kernel.org, gregkh@linuxfoundation.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Gene Chen <gene_chen@richtek.com>,
benjamin.chao@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com
Subject: Re: [PATCH 9/9] mfd: mt6360: Merge different sub-devices I2C read/write
Date: Thu, 6 Aug 2020 13:13:32 +0100 [thread overview]
Message-ID: <20200806121332.GB6442@sirena.org.uk> (raw)
In-Reply-To: <CAE+NS360iKLoGxiiz8NmQqCp2Uge98Eehe4g2sn_N0e-E3DgyQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
On Thu, Aug 06, 2020 at 11:30:56AM +0800, Gene Chen wrote:
> Mark Brown <broonie@kernel.org> 於 2020年8月6日 週四 上午12:10寫道：
> > It's not clear why this isn't just done in the device regmap, there's
> > exactly one user?
> because I use one regmap to access 4 I2C devices,
There appears to be only one device here?
> I need change the regmap_bus struct to fit I2C read/write with CRC bit
> Therefore, MFD reviewer suggests I can move the regmap api to regmap
> folder such as regmap-ac97.c
AC'97 is an industry standard bus used by a range of devices in
different subsystems. You can already have custom operations for a
device just in a regular regmap using the reg_read() and reg_write()
operations which are there so devices that individual device support
doesn't need to be added to the regmap core.
You really also need to write a much clearer changelog, I would be hard
pressed to tell from the changelog that this was moving things to the
regmap core rather than shuffling regmaps within the device.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-06 16:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 16:32 [PATCH v3 0/9] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2020-08-04 16:32 ` [PATCH 1/9] mfd: mt6360: Rearrange include file Gene Chen
2020-08-04 16:32 ` [PATCH 2/9] mfd: mt6360: Remove redundant brackets around raw numbers Gene Chen
2020-08-04 16:32 ` [PATCH 3/9] mfd: mt6360: Indicate sub-dev compatible name by using "-" Gene Chen
2020-08-04 16:32 ` [PATCH 4/9] mfd: mt6360: Combine mt6360 pmic/ldo resources into mt6360 regulator resources Gene Chen
2020-08-04 16:32 ` [PATCH 5/9] mfd: mt6360: Rename mt6360_pmu_data by mt6360_data Gene Chen
2020-08-04 16:32 ` [PATCH 5/9] mfd: mt6360: Rename mt6360_pmu_data by mt6360_ddata Gene Chen
2020-08-04 16:32 ` [PATCH 6/9] mfd: mt6360: Rename mt6360_pmu by mt6360 Gene Chen
2020-08-04 16:33 ` [PATCH 7/9] mfd: mt6360: Remove handle_post_irq callback function Gene Chen
2020-08-04 16:33 ` [PATCH 8/9] mfd: mt6360: Fix flow which is used to check ic exist Gene Chen
2020-08-04 16:33 ` [PATCH 9/9] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2020-08-05 16:10 ` Mark Brown
2020-08-06 3:30 ` Gene Chen
2020-08-06 12:13 ` Mark Brown [this message]
2020-08-07 2:16 ` Gene Chen
2020-08-07 11:13 ` Mark Brown
2020-08-10 7:08 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806121332.GB6442@sirena.org.uk \
--to=broonie@kernel.org \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).