From: peterz@infradead.org
To: "Jürgen Groß" <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Deep Shah <sdeep@vmware.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL
Date: Fri, 7 Aug 2020 12:21:58 +0200 [thread overview]
Message-ID: <20200807102158.GG2674@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3a0712ee-efca-5684-d321-3b789e01fc16@suse.com>
On Fri, Aug 07, 2020 at 12:02:59PM +0200, Jürgen Groß wrote:
> On 07.08.20 11:39, peterz@infradead.org wrote:
> > On Fri, Aug 07, 2020 at 10:38:23AM +0200, Juergen Gross wrote:
> >
> > > -# else
> > > - const unsigned char cpu_iret[1];
> > > -# endif
> > > };
> > > static const struct patch_xxl patch_data_xxl = {
> > > @@ -42,7 +38,6 @@ static const struct patch_xxl patch_data_xxl = {
> > > .irq_save_fl = { 0x9c, 0x58 }, // pushf; pop %[re]ax
> > > .mmu_read_cr2 = { 0x0f, 0x20, 0xd0 }, // mov %cr2, %[re]ax
> > > .mmu_read_cr3 = { 0x0f, 0x20, 0xd8 }, // mov %cr3, %[re]ax
> > > -# ifdef CONFIG_X86_64
> > > .mmu_write_cr3 = { 0x0f, 0x22, 0xdf }, // mov %rdi, %cr3
> > > .irq_restore_fl = { 0x57, 0x9d }, // push %rdi; popfq
> > > .cpu_wbinvd = { 0x0f, 0x09 }, // wbinvd
> > > @@ -50,19 +45,11 @@ static const struct patch_xxl patch_data_xxl = {
> > > 0x48, 0x0f, 0x07 }, // swapgs; sysretq
> > > .cpu_swapgs = { 0x0f, 0x01, 0xf8 }, // swapgs
> > > .mov64 = { 0x48, 0x89, 0xf8 }, // mov %rdi, %rax
> > > -# else
> > > - .mmu_write_cr3 = { 0x0f, 0x22, 0xd8 }, // mov %eax, %cr3
> > > - .irq_restore_fl = { 0x50, 0x9d }, // push %eax; popf
> > > - .cpu_iret = { 0xcf }, // iret
> > > -# endif
> >
> > I was looking at x86_64 paravirt the other day and found we actually
> > have pv_ops.cpu.iret users there..
>
> On x86_64 we have (without PARAVIRT_XXL):
>
> #define INTERRUPT_RETURN jmp native_iret
>
> and with PARAVIRT_XXL this is basically a jmp *pv_ops.cpu.iret which
> will then be patched to either jmp native_iret or jmp xen_iret.
Ah, okay. Clearly I didn't look hard enough. Thanks!
next prev parent reply other threads:[~2020-08-07 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 8:38 [PATCH v3 0/7] Remove 32-bit Xen PV guest support Juergen Gross
2020-08-07 8:38 ` [PATCH v3 1/7] x86/xen: remove " Juergen Gross
2020-08-09 2:01 ` Boris Ostrovsky
2020-08-10 4:36 ` Jürgen Groß
2020-08-07 8:38 ` [PATCH v3 2/7] x86/xen: eliminate xen-asm_64.S Juergen Gross
2020-08-09 2:04 ` Boris Ostrovsky
2020-08-10 4:36 ` Jürgen Groß
2020-08-07 8:38 ` [PATCH v3 3/7] x86/xen: drop tests for highmem in pv code Juergen Gross
2020-08-07 11:18 ` kernel test robot
2020-08-09 2:22 ` Boris Ostrovsky
2020-08-10 4:37 ` Jürgen Groß
2020-08-07 8:38 ` [PATCH v3 4/7] x86/paravirt: remove 32-bit support from PARAVIRT_XXL Juergen Gross
2020-08-07 9:39 ` peterz
2020-08-07 10:02 ` Jürgen Groß
2020-08-07 10:21 ` peterz [this message]
2020-08-09 2:34 ` Boris Ostrovsky
2020-08-10 4:39 ` Jürgen Groß
2020-08-10 16:53 ` Boris Ostrovsky
2020-08-10 18:42 ` Jürgen Groß
2020-08-07 8:38 ` [PATCH v3 5/7] x86/paravirt: cleanup paravirt macros Juergen Gross
2020-08-07 8:38 ` [PATCH v3 6/7] x86/paravirt: use CONFIG_PARAVIRT_XXL instead of CONFIG_PARAVIRT Juergen Gross
2020-08-07 8:38 ` [PATCH v3 7/7] x86/entry/32: revert "Fix XEN_PV build dependency" Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807102158.GG2674@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pv-drivers@vmware.com \
--cc=sdeep@vmware.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).