From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Max Filippov <jcmvbkbc@gmail.com>, Rich Felker <dalias@libc.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Karcher <kernel@mkarcher.dialup.fu-berlin.de>
Subject: Re: linux-next: manual merge of the xtensa tree with the sh tree
Date: Fri, 7 Aug 2020 10:42:30 +1000 [thread overview]
Message-ID: <20200807104230.7f659cbb@canb.auug.org.au> (raw)
In-Reply-To: <20200728102330.11f78570@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 2661 bytes --]
Hi all,
On Tue, 28 Jul 2020 10:23:30 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the xtensa tree got a conflict in:
>
> tools/testing/selftests/seccomp/seccomp_bpf.c
>
> between commit:
>
> 469023465e79 ("sh: Add SECCOMP_FILTER")
>
> from the sh tree and commit:
>
> deccfc9ce639 ("selftests/seccomp: add xtensa support")
>
> from the xtensa tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> diff --cc tools/testing/selftests/seccomp/seccomp_bpf.c
> index 06d994a34997,1b445c2e7fbe..000000000000
> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> @@@ -124,8 -122,8 +124,10 @@@ struct seccomp_data
> # define __NR_seccomp 358
> # elif defined(__s390__)
> # define __NR_seccomp 348
> +# elif defined(__sh__)
> +# define __NR_seccomp 372
> + # elif defined(__xtensa__)
> + # define __NR_seccomp 337
> # else
> # warning "seccomp syscall number unknown for this architecture"
> # define __NR_seccomp 0xffff
> @@@ -1634,10 -1624,14 +1636,18 @@@ TEST_F(TRACE_poke, getpid_runs_normally
> # define SYSCALL_SYSCALL_NUM regs[4]
> # define SYSCALL_RET regs[2]
> # define SYSCALL_NUM_RET_SHARE_REG
> +#elif defined(__sh__)
> +# define ARCH_REGS struct pt_regs
> +# define SYSCALL_NUM gpr[3]
> +# define SYSCALL_RET gpr[0]
> + #elif defined(__xtensa__)
> + # define ARCH_REGS struct user_pt_regs
> + # define SYSCALL_NUM syscall
> + /*
> + * On xtensa syscall return value is in the register
> + * a2 of the current window which is not fixed.
> + */
> + #define SYSCALL_RET(reg) a[(reg).windowbase * 4 + 2]
> #else
> # error "Do not know how to find your architecture's registers and syscalls"
> #endif
> @@@ -1710,7 -1704,7 +1720,7 @@@ void change_syscall(struct __test_metad
>
> #if defined(__x86_64__) || defined(__i386__) || defined(__powerpc__) || \
> defined(__s390__) || defined(__hppa__) || defined(__riscv) || \
> - defined(__csky__) || defined(__sh__)
> - defined(__xtensa__)
> ++ defined(__csky__) || defined(__sh__) || defined(__xtensa__)
> {
> regs.SYSCALL_NUM = syscall;
> }
This is now a conflict between the sh tree and Linus' tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-08-07 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 0:23 linux-next: manual merge of the xtensa tree with the sh tree Stephen Rothwell
2020-08-07 0:42 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807104230.7f659cbb@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=dalias@libc.org \
--cc=jcmvbkbc@gmail.com \
--cc=kernel@mkarcher.dialup.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).