From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFE0CC433E0 for ; Fri, 7 Aug 2020 09:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D71A4206B5 for ; Fri, 7 Aug 2020 09:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbgHGJbt (ORCPT ); Fri, 7 Aug 2020 05:31:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:34548 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbgHGJbt (ORCPT ); Fri, 7 Aug 2020 05:31:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 992C1AC55; Fri, 7 Aug 2020 09:32:05 +0000 (UTC) Date: Fri, 7 Aug 2020 11:31:46 +0200 From: Jean Delvare To: Bartosz Golaszewski Cc: LKML , Linux I2C , Bartosz Golaszewski , Arnd Bergmann , Greg Kroah-Hartman Subject: Re: VAIO EEPROM support in at24 Message-ID: <20200807113146.7557c18b@endymion> In-Reply-To: <20200805163655.6cfa6e17@endymion> References: <20200317151409.7940926c@endymion> <20200805163655.6cfa6e17@endymion> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Aug 2020 16:36:55 +0200, Jean Delvare wrote: > 1* Do we actually need to use a struct resource? With the current > requirements, that looks overkill to me. We really only need the > start and end offsets of the masked area (or start and length). Or > do you plan to ever support multiple masked ranges, and > resource.child would be used to daisy-chain these ranges? Personally > I would wait until the need exists. Dang, turns out that the need already exists. I just found that the eeprom driver masks *2* areas of the Sony VAIO EEPROMs. I should know because I'm the one who made that change but that was 13 years ago and my memory doesn't go that far back. I'll think of a way to support that. Still not a big fan of daisy-chained resource structs though. Maybe a generic post-processing callback function would do... I'll give that a try. -- Jean Delvare SUSE L3 Support