From: Mark Brown <broonie@kernel.org>
To: "RAVULAPATI, VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
YueHaibing <yuehaibing@huawei.com>,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: Replacing component->name with codec_dai->name
Date: Fri, 7 Aug 2020 12:54:14 +0100 [thread overview]
Message-ID: <20200807115414.GI5435@sirena.org.uk> (raw)
In-Reply-To: <BY5PR12MB429286C315F66F7E2E5EA501E7490@BY5PR12MB4292.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Fri, Aug 07, 2020 at 08:36:25AM +0000, RAVULAPATI, VISHNU VARDHAN RAO wrote:
> On Thu, Aug 06, 2020 at 03:44:12PM +0530, Ravulapati Vishnu vardhan rao wrote:
> > Replacing string compare with codec_dai->name instead of comparing
> > with codec_dai->component->name in hw_params.
> >Why?
> Here the component name for codec RT1015 is "i2c-10EC1015:00" and will never be "rt1015-aif1"
> As it is codec-dai->name so the strcmp always compares and fails to set the sysclk,pll,bratio of expected codec-dai
This should be in the changelog so people can understand why the change
was made.
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-07 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 10:14 [PATCH] ASoC: amd: Replacing component->name with codec_dai->name Ravulapati Vishnu vardhan rao
2020-08-06 11:28 ` Mark Brown
2020-08-07 8:09 ` RAVULAPATI, VISHNU VARDHAN RAO
2020-08-07 8:36 ` RAVULAPATI, VISHNU VARDHAN RAO
2020-08-07 11:54 ` Mark Brown [this message]
2020-08-10 18:57 ` Mark Brown
2020-08-07 16:10 Ravulapati Vishnu vardhan rao
2020-08-10 18:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807115414.GI5435@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).