From: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To: <maz@kernel.org>, Daniel Palmer <daniel@0x0f.com>,
Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: <alix.wu@mediatek.com>, <devicetree@vger.kernel.org>,
<jason@lakedaemon.net>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <matthias.bgg@gmail.com>,
<robh+dt@kernel.org>, <tglx@linutronix.de>,
<yj.chiang@mediatek.com>
Subject: Re: [PATCH 0/2] irqchip: irq-mt58xx: Add mt58xx series interrupt
Date: Fri, 7 Aug 2020 20:52:04 +0800 [thread overview]
Message-ID: <20200807125204.2739-1-mark-pk.tsai@mediatek.com> (raw)
In-Reply-To: <654a81dcefb3024d762ff338d4bd7f14@kernel.org>
From: Marc Zyngier <maz@kernel.org>
> On 2020-08-06 15:58, Daniel Palmer wrote:
> > Hi Mark-PK,
> >
> > On Thu, 6 Aug 2020 at 23:08, Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > wrote:
> >> > Do you know if it would be possible to confirm if they are
> >> > the
> >> > same thing? MediaTek bought MStar a few years ago so it seems likely
> >> > but I have no hard information.
> >> >
> >>
> >> Yes, it's for the same interrupt controller IP.
> >
> > That's good news. :)
> >
> >> > If they are the same thing could we work on making one series that
> >> > supports both use cases?
> >>
> >> Sure, and I think the irq controller driver should support both use
> >> cases.
> >> So how about keep the MTK version driver?
> >
> > I'm fine with that. Maybe you can push the MTK version and I can send
> > a small patch after that to add the small bits I need?
>
> In the interest of being vendor agnostic, please rename the properties
> such as mediatek,irqs-map-range to something less brand-specific.
> The compatible string should be enough.
I can't find the suitable property in standard ones that match the custom
properties here.
And the vendor prefixed rule is described in [1].
The interrupt controller is first used in Mstar TV SoCs.
Now it's used in MTK TV and Sigmastar SoCs.
So I think Mstar prefixed would make more sense.
I will rename the driver into mstar-intc, and MTK will maintain this driver.
[1] https://www.kernel.org/doc/Documentation/devicetree/booting-without-of.txt
prev parent reply other threads:[~2020-08-07 12:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:22 [PATCH 0/2] irqchip: irq-mt58xx: Add mt58xx series interrupt Mark-PK Tsai
2020-08-03 6:22 ` [PATCH 1/2] irqchip: irq-mt58xx: Add mt58xx interrupt controller support Mark-PK Tsai
2020-08-03 8:04 ` Marc Zyngier
2020-08-03 15:52 ` Marc Zyngier
2020-08-03 15:03 ` Mark-PK Tsai
2020-08-03 6:22 ` [PATCH 2/2] dt-bindings: interrupt-controller: Add MT58XX interrupt controller Mark-PK Tsai
2020-08-03 21:47 ` Rob Herring
2020-08-06 10:12 ` [PATCH 0/2] irqchip: irq-mt58xx: Add mt58xx series interrupt Daniel Palmer
2020-08-06 14:07 ` Mark-PK Tsai
2020-08-06 14:58 ` Daniel Palmer
2020-08-06 15:12 ` Marc Zyngier
2020-08-07 12:52 ` Mark-PK Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807125204.2739-1-mark-pk.tsai@mediatek.com \
--to=mark-pk.tsai@mediatek.com \
--cc=alix.wu@mediatek.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).