From: Stephen Kitt <steve@sk2.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hwmon/pmbus: use simple i2c probe function
Date: Fri, 7 Aug 2020 18:23:06 +0200 [thread overview]
Message-ID: <20200807182306.032376e5@heffalump.sk2.org> (raw)
In-Reply-To: <caf1963d-860f-1b46-49e5-ad3acc8d7877@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
On Fri, 7 Aug 2020 08:23:29 -0700, Guenter Roeck <linux@roeck-us.net> wrote:
> On 8/7/20 12:45 AM, Stephen Kitt wrote:
> > pmbus_do_probe doesn't use the id information provided in its second
> > argument, so this can be removed, which then allows using the
> > single-parameter i2c probe function ("probe_new") for probes.
> >
> > This avoids scanning the identifier tables during probes.
> >
> > Drivers which didn't use the id are converted as-is; drivers which did
> > are modified as follows:
> >
> > * if the information in i2c_client is sufficient, that's used instead
> > (client->name);
> > * configured v. probed comparisons are performed by comparing the
> > configured name to the detected name, instead of the ids; this
> > involves strcmp but is still cheaper than comparing all the device
> > names when scanning the tables;
> > * anything else is handled by calling i2c_match_id() with the same
> > level of error-handling (if any) as before.
> >
> > Signed-off-by: Stephen Kitt <steve@sk2.org>
>
> Please also update the documentation.
>
> Documentation/hwmon/pmbus-core.rst: int pmbus_do_probe(struct i2c_client
> *client, const struct i2c_device_id *id, Documentation/hwmon/pmbus.rst:
> return pmbus_do_probe(client, id, &ds1200_info);
Aargh, I usually *start* from the documentation, but I didn’t think to check
in this case.
> Also, please fix the checkpatch issue reported by Wolfram.
Will do, v3 on its way.
Thanks for the reviews!
Regards,
Stephen
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-08-07 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 7:45 [PATCH v2] hwmon/pmbus: use simple i2c probe function Stephen Kitt
2020-08-07 9:08 ` Wolfram Sang
2020-08-07 15:23 ` Guenter Roeck
2020-08-07 16:23 ` Stephen Kitt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807182306.032376e5@heffalump.sk2.org \
--to=steve@sk2.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).