From: Jiri Olsa <jolsa@redhat.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [RFC] libperf: Add support for user space counter access
Date: Sat, 8 Aug 2020 12:22:08 +0200 [thread overview]
Message-ID: <20200808102208.GA619980@krava> (raw)
In-Reply-To: <20200807230517.57114-1-robh@kernel.org>
On Fri, Aug 07, 2020 at 05:05:17PM -0600, Rob Herring wrote:
> x86 and arm64 can both support direct access of event counters in
> userspace. The access sequence is less than trivial and currently exists
> in perf test code (tools/perf/arch/x86/tests/rdpmc.c) with copies in
> projects such as PAPI and libpfm4.
>
> Patches to add arm64 userspace support are pending[1].
>
> For this RFC, looking for a yes, seems like a good idea, or no, go away we
> don't want this in libperf.
hi,
looks great!
I wanted to add this for very long time.. so yes, we want this ;-)
>
> TODO:
> - Handle userspace access not enabled.
> - Handle pmc_width and cap_user_time_short in read loop.
> - Move existing rdpmc test to libperf based test?
> - Abstract out rdtsc/rdpmc (currently only builds on x86 and need to add
> Arm versions)
all of them seem good, also please add test for perf_mmap__read_self
itself and update the doc/man
SNIP
> +{
> + struct perf_event_mmap_page *pc = map->base;
> + u32 seq, idx, time_mult = 0, time_shift = 0;
> + u64 count, cyc = 0, time_offset = 0, enabled, running, delta;
> +
> + /*
> + * Check if event was unmapped due to a POLLHUP/POLLERR.
> + */
> + if (!refcount_read(&map->refcnt))
> + return ~0;
> +
> + do {
> + seq = pc->lock;
> + barrier();
> +
> + enabled = pc->time_enabled;
> + running = pc->time_running;
> +
> + if (enabled != running) {
should you check pc->cap_usr_time in here?
> + cyc = rdtsc();
> + time_mult = pc->time_mult;
> + time_shift = pc->time_shift;
> + time_offset = pc->time_offset;
> + }
> +
> + idx = pc->index;
> + count = pc->offset;
> + if (idx)
and pc->cap_user_rdpmc in here?
ok, it's probably in the TODO
thanks,
jirka
next prev parent reply other threads:[~2020-08-08 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 23:05 [RFC] libperf: Add support for user space counter access Rob Herring
2020-08-08 10:22 ` Jiri Olsa [this message]
2020-08-10 18:11 ` Rob Herring
2020-08-11 10:50 ` Jiri Olsa
2020-08-11 11:02 ` peterz
2020-08-11 16:49 ` Rob Herring
2020-08-12 13:05 ` Jiri Olsa
2020-08-10 20:24 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808102208.GA619980@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).