* [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed
@ 2020-08-09 7:29 Christophe JAILLET
2020-08-10 14:00 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Christophe JAILLET @ 2020-08-09 7:29 UTC (permalink / raw)
To: balbi, gregkh, thierry.reding, jonathanh, nkristam, yuehaibing,
heikki.krogerus
Cc: linux-usb, linux-tegra, linux-kernel, kernel-janitors,
Christophe JAILLET
There is no need to use GFP_ATOMIC here. It is a probe function, no
spinlock is taken.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/usb/gadget/udc/tegra-xudc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index d6ff68c06911..9aa4815c1c59 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -3733,7 +3733,7 @@ static int tegra_xudc_probe(struct platform_device *pdev)
unsigned int i;
int err;
- xudc = devm_kzalloc(&pdev->dev, sizeof(*xudc), GFP_ATOMIC);
+ xudc = devm_kzalloc(&pdev->dev, sizeof(*xudc), GFP_KERNEL);
if (!xudc)
return -ENOMEM;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed
2020-08-09 7:29 [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed Christophe JAILLET
@ 2020-08-10 14:00 ` Thierry Reding
2020-08-11 1:18 ` JC Kuo
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2020-08-10 14:00 UTC (permalink / raw)
To: Christophe JAILLET, Nagarjuna Kristam
Cc: balbi, gregkh, jonathanh, yuehaibing, heikki.krogerus, linux-usb,
linux-tegra, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote:
> There is no need to use GFP_ATOMIC here. It is a probe function, no
> spinlock is taken.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good to me. I can't think of any reason why this would have to be
an atomic allocation. Nagarjuna, please shout if this is really needed,
otherwise:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed
2020-08-10 14:00 ` Thierry Reding
@ 2020-08-11 1:18 ` JC Kuo
0 siblings, 0 replies; 3+ messages in thread
From: JC Kuo @ 2020-08-11 1:18 UTC (permalink / raw)
To: Thierry Reding, Christophe JAILLET, Nagarjuna Kristam
Cc: balbi, gregkh, jonathanh, yuehaibing, heikki.krogerus, linux-usb,
linux-tegra, linux-kernel, kernel-janitors
Looks good to me.
Reviewed-by: JC Kuo <jckuo@nvidia.com>
On 8/10/20 10:00 PM, Thierry Reding wrote:
> On Sun, Aug 09, 2020 at 09:29:48AM +0200, Christophe JAILLET wrote:
>> There is no need to use GFP_ATOMIC here. It is a probe function, no
>> spinlock is taken.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> drivers/usb/gadget/udc/tegra-xudc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Looks good to me. I can't think of any reason why this would have to be
> an atomic allocation. Nagarjuna, please shout if this is really needed,
> otherwise:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-11 1:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-09 7:29 [PATCH] usb: gadget: tegra-xudc: Avoid GFP_ATOMIC where it is not needed Christophe JAILLET
2020-08-10 14:00 ` Thierry Reding
2020-08-11 1:18 ` JC Kuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).