From: Sudeep Holla <sudeep.holla@arm.com>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <robh+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 2/2] dt-bindings: cpufreq: Document Krait CPU Cache scaling
Date: Mon, 10 Aug 2020 09:01:46 +0100 [thread overview]
Message-ID: <20200810080146.GA31434@bogus> (raw)
In-Reply-To: <20200807234914.7341-3-ansuelsmth@gmail.com>
On Sat, Aug 08, 2020 at 01:49:12AM +0200, Ansuel Smith wrote:
> Document dedicated Krait CPU Cache Scaling driver.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../bindings/cpufreq/krait-cache-scale.yaml | 92 +++++++++++++++++++
> 1 file changed, 92 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/krait-cache-scale.yaml
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/krait-cache-scale.yaml b/Documentation/devicetree/bindings/cpufreq/krait-cache-scale.yaml
> new file mode 100644
> index 000000000000..f10b1f386a99
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/krait-cache-scale.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/cpufreq/krait-cache-scale.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Krait Cpu Cache Frequency Scaling dedicated driver
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +description: |
> + This Scale the Krait CPU Cache Frequency and optionally voltage
> + when the Cpu Frequency is changed (using the cpufreq notifier).
> +
> + Cache is scaled with the max frequency across all core and the cache
> + frequency will scale based on the configured threshold in the dts.
> +
> + The cache is hardcoded to 3 frequency bin, idle, nominal and high.
> +
> +properties:
> + compatible:
> + const: qcom,krait-cache
> +
How does this fit in the standard cache hierarchy nodes ? Extend the
example to cover that.
> + clocks:
> + description: Phandle to the L2 CPU clock
> +
> + clock-names:
> + const: "l2"
> +
> + voltage-tolerance:
> + description: Same voltage tollerance of the Krait CPU
> +
> + l2-rates:
> + description: |
> + Frequency the L2 cache will be scaled at.
> + Value is in Hz.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + items:
> + - description: idle
> + - description: nominal
> + - description: high
> +
Why can't you re-use the standard OPP v2 bindings ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2020-08-10 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 23:49 [RFC PATCH v2 0/2] Add Krait Cache Scaling support Ansuel Smith
2020-08-07 23:49 ` [RFC PATCH v2 1/2] cpufreq: qcom: " Ansuel Smith
2020-08-07 23:49 ` [RFC PATCH v2 2/2] dt-bindings: cpufreq: Document Krait CPU Cache scaling Ansuel Smith
2020-08-10 8:01 ` Sudeep Holla [this message]
2020-08-10 11:15 ` R: " ansuelsmth
2020-08-10 12:45 ` Sudeep Holla
2020-08-10 12:51 ` R: " ansuelsmth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810080146.GA31434@bogus \
--to=sudeep.holla@arm.com \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).