linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: fix pointer table overallocation
Date: Mon, 10 Aug 2020 13:37:47 +0100	[thread overview]
Message-ID: <20200810123747.GC6438@sirena.org.uk> (raw)
In-Reply-To: <5ef51b56-c533-46c8-621d-7907129594e9@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

On Sun, Aug 09, 2020 at 10:44:25PM +0300, Dmitry Osipenko wrote:
> 09.08.2020 22:21, Michał Mirosław пишет:
> > The code allocates sizeof(regulator_dev) for a pointer. Make it less
> > generous. Let kcalloc() calculate the size, while at it.
> > 
> > Cc: stable@vger.kernel.org
> > Fixes: d8ca7d184b33 ("regulator: core: Introduce API for regulators coupling customization")

> Hello, Michał! Thank you for the patch! Not sure whether it's worthwhile
> to backport this change since it's an improvement, I'll leave it to Mark
> to decide, otherwise looks good to me.

Yeah, this is more a performance improvement than a fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-08-10 12:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-09 19:21 [PATCH] regulator: fix pointer table overallocation Michał Mirosław
2020-08-09 19:44 ` Dmitry Osipenko
2020-08-10 12:37   ` Mark Brown [this message]
2020-08-10 16:25     ` Michał Mirosław
2020-08-10 17:33       ` Mark Brown
2020-08-10 19:20         ` Michał Mirosław

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810123747.GC6438@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=digetx@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).