From: Daniel Vetter <daniel@ffwll.ch>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/vkms: add missing platform_device_unregister() in vkms_init()
Date: Mon, 10 Aug 2020 15:32:38 +0200 [thread overview]
Message-ID: <20200810133238.GW2352366@phenom.ffwll.local> (raw)
In-Reply-To: <20200810130011.187691-1-miaoqinglang@huawei.com>
On Mon, Aug 10, 2020 at 09:00:11PM +0800, Qinglang Miao wrote:
> When vkms_init() get into out_put, the unregister call of
> vkms_device->platform is missing. So add it before return.
>
> Fixes: c27f0cc4d43a "drm/vkms: enable cursor by default"
This is the wrong commit, I fixed that up while applying.
-Daniel
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 57a8a397d..83dd5567d 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -190,8 +190,8 @@ static int __init vkms_init(void)
>
> out_put:
> drm_dev_put(&vkms_device->drm);
> + platform_device_unregister(vkms_device->platform);
> return ret;
> -
> out_unregister:
> platform_device_unregister(vkms_device->platform);
> out_free:
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2020-08-10 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 13:00 [PATCH] drm/vkms: add missing platform_device_unregister() in vkms_init() Qinglang Miao
2020-08-10 13:32 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810133238.GW2352366@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).