From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Zhao Heming <heming.zhao@suse.com>,
Song Liu <songliubraving@fb.com>, Sasha Levin <sashal@kernel.org>,
linux-raid@vger.kernel.org
Subject: [PATCH AUTOSEL 4.19 10/31] md-cluster: fix wild pointer of unlock_all_bitmaps()
Date: Mon, 10 Aug 2020 15:12:38 -0400 [thread overview]
Message-ID: <20200810191259.3794858-10-sashal@kernel.org> (raw)
In-Reply-To: <20200810191259.3794858-1-sashal@kernel.org>
From: Zhao Heming <heming.zhao@suse.com>
[ Upstream commit 60f80d6f2d07a6d8aee485a1d1252327eeee0c81 ]
reproduction steps:
```
node1 # mdadm -C /dev/md0 -b clustered -e 1.2 -n 2 -l mirror /dev/sda
/dev/sdb
node2 # mdadm -A /dev/md0 /dev/sda /dev/sdb
node1 # mdadm -G /dev/md0 -b none
mdadm: failed to remove clustered bitmap.
node1 # mdadm -S --scan
^C <==== mdadm hung & kernel crash
```
kernel stack:
```
[ 335.230657] general protection fault: 0000 [#1] SMP NOPTI
[...]
[ 335.230848] Call Trace:
[ 335.230873] ? unlock_all_bitmaps+0x5/0x70 [md_cluster]
[ 335.230886] unlock_all_bitmaps+0x3d/0x70 [md_cluster]
[ 335.230899] leave+0x10f/0x190 [md_cluster]
[ 335.230932] ? md_super_wait+0x93/0xa0 [md_mod]
[ 335.230947] ? leave+0x5/0x190 [md_cluster]
[ 335.230973] md_cluster_stop+0x1a/0x30 [md_mod]
[ 335.230999] md_bitmap_free+0x142/0x150 [md_mod]
[ 335.231013] ? _cond_resched+0x15/0x40
[ 335.231025] ? mutex_lock+0xe/0x30
[ 335.231056] __md_stop+0x1c/0xa0 [md_mod]
[ 335.231083] do_md_stop+0x160/0x580 [md_mod]
[ 335.231119] ? 0xffffffffc05fb078
[ 335.231148] md_ioctl+0xa04/0x1930 [md_mod]
[ 335.231165] ? filename_lookup+0xf2/0x190
[ 335.231179] blkdev_ioctl+0x93c/0xa10
[ 335.231205] ? _cond_resched+0x15/0x40
[ 335.231214] ? __check_object_size+0xd4/0x1a0
[ 335.231224] block_ioctl+0x39/0x40
[ 335.231243] do_vfs_ioctl+0xa0/0x680
[ 335.231253] ksys_ioctl+0x70/0x80
[ 335.231261] __x64_sys_ioctl+0x16/0x20
[ 335.231271] do_syscall_64+0x65/0x1f0
[ 335.231278] entry_SYSCALL_64_after_hwframe+0x44/0xa9
```
Signed-off-by: Zhao Heming <heming.zhao@suse.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/md/md-cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c
index 0b2af6e74fc37..4522e87d9d68d 100644
--- a/drivers/md/md-cluster.c
+++ b/drivers/md/md-cluster.c
@@ -1443,6 +1443,7 @@ static void unlock_all_bitmaps(struct mddev *mddev)
}
}
kfree(cinfo->other_bitmap_lockres);
+ cinfo->other_bitmap_lockres = NULL;
}
}
--
2.25.1
next prev parent reply other threads:[~2020-08-10 19:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 19:12 [PATCH AUTOSEL 4.19 01/31] drm/tilcdc: fix leak & null ref in panel_connector_get_modes Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 02/31] soc: qcom: rpmh-rsc: Set suppress_bind_attrs flag Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 03/31] Bluetooth: add a mutex lock to avoid UAF in do_enale_set Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 04/31] loop: be paranoid on exit and prevent new additions / removals Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 05/31] fs/btrfs: Add cond_resched() for try_release_extent_mapping() stalls Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 06/31] drm/amdgpu: avoid dereferencing a NULL pointer Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 07/31] drm/radeon: Fix reference count leaks caused by pm_runtime_get_sync Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 08/31] crypto: aesni - Fix build with LLVM_IAS=1 Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 09/31] video: fbdev: neofb: fix memory leak in neo_scan_monitor() Sasha Levin
2020-08-10 19:12 ` Sasha Levin [this message]
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 11/31] arm64: dts: hisilicon: hikey: fixes to comply with adi, adv7533 DT binding Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 12/31] drm/etnaviv: fix ref count leak via pm_runtime_get_sync Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 13/31] drm/nouveau: fix multiple instances of reference count leaks Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 14/31] usb: mtu3: clear dual mode of u3port when disable device Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 15/31] drm/debugfs: fix plain echo to connector "force" attribute Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 16/31] drm/radeon: disable AGP by default Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 17/31] irqchip/irq-mtk-sysirq: Replace spinlock with raw_spinlock Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 18/31] mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 19/31] brcmfmac: keep SDIO watchdog running when console_interval is non-zero Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 20/31] brcmfmac: To fix Bss Info flag definition Bug Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 21/31] brcmfmac: set state of hanger slot to FREE when flushing PSQ Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 22/31] iwlegacy: Check the return value of pcie_capability_read_*() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 23/31] gpu: host1x: debug: Fix multiple channels emitting messages simultaneously Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 24/31] usb: gadget: net2280: fix memory leak on probe error handling paths Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 25/31] bdc: Fix bug causing crash after multiple disconnects Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 26/31] usb: bdc: Halt controller on suspend Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 27/31] dyndbg: fix a BUG_ON in ddebug_describe_flags Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 28/31] dyndbg: prefer declarative init in caller, to memset in callee Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 29/31] bcache: fix super block seq numbers comparision in register_cache_set() Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 30/31] ACPICA: Do not increment operation_region reference counts for field units Sasha Levin
2020-08-10 19:12 ` [PATCH AUTOSEL 4.19 31/31] drm/msm: ratelimit crtc event overflow error Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810191259.3794858-10-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=heming.zhao@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).