linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Trond Myklebust <trondmy@gmail.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the nfs tree
Date: Wed, 12 Aug 2020 09:10:21 +1000	[thread overview]
Message-ID: <20200812091021.7865278d@canb.auug.org.au> (raw)
In-Reply-To: <20200807103640.116e82f6@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 3908 bytes --]

Hi all,

On Fri, 7 Aug 2020 10:36:40 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the nfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> In file included from include/trace/define_trace.h:102,
>                  from fs/nfs/nfs4trace.h:2316,
>                  from fs/nfs/nfs4trace.c:13:
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_read_event':
> fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
>  1767 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
>  1759 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_write_event':
> fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
>  1844 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
>  1836 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'trace_event_raw_event_nfs4_commit_event':
> fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
>  1917 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/trace_events.h:707:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>   707 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
>  1911 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> In file included from include/trace/define_trace.h:103,
>                  from fs/nfs/nfs4trace.h:2316,
>                  from fs/nfs/nfs4trace.c:13:
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_read_event':
> fs/nfs/./nfs4trace.h:1767:34: warning: unused variable 'lo' [-Wunused-variable]
>  1767 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1759:3: note: in expansion of macro 'TP_fast_assign'
>  1759 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_write_event':
> fs/nfs/./nfs4trace.h:1844:34: warning: unused variable 'lo' [-Wunused-variable]
>  1844 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1836:3: note: in expansion of macro 'TP_fast_assign'
>  1836 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> fs/nfs/./nfs4trace.h: In function 'perf_trace_nfs4_commit_event':
> fs/nfs/./nfs4trace.h:1917:34: warning: unused variable 'lo' [-Wunused-variable]
>  1917 |    const struct pnfs_layout_hdr *lo = lseg ?
>       |                                  ^~
> include/trace/perf.h:66:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
>    66 |  { assign; }       \
>       |    ^~~~~~
> fs/nfs/./nfs4trace.h:1911:3: note: in expansion of macro 'TP_fast_assign'
>  1911 |   TP_fast_assign(
>       |   ^~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   34daa637f2b2 ("NFS: Add layout segment info to pnfs read/write/commit tracepoints")

I am still getting this warning ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-08-11 23:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  0:36 linux-next: build warning after merge of the nfs tree Stephen Rothwell
2020-08-11 23:10 ` Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-06-05  0:17 Stephen Rothwell
2018-06-05 14:53 ` Trond Myklebust
2018-06-05 14:53   ` Trond Myklebust
2018-01-15 21:44 Stephen Rothwell
2015-10-20  4:37 Stephen Rothwell
2014-06-17  1:26 Stephen Rothwell
2012-03-20  8:34 Stephen Rothwell
2012-03-20 13:28 ` Myklebust, Trond
2012-03-20  2:14 Stephen Rothwell
2010-08-04  1:32 Stephen Rothwell
2010-08-04  2:09 ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200812091021.7865278d@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=trondmy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).