From: Rob Herring <robh@kernel.org>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>
Cc: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display
Date: Wed, 12 Aug 2020 10:55:04 -0600 [thread overview]
Message-ID: <20200812165504.GA2361465@bogus> (raw)
In-Reply-To: <1596855231-5782-2-git-send-email-yongqiang.niu@mediatek.com>
On Sat, Aug 08, 2020 at 10:53:45AM +0800, Yongqiang Niu wrote:
> rdma fifo size may be different even in same SOC, add this
> property to the corresponding rdma
>
> Change-Id: I67635ec7f3f59cf4cbc7737285e5e28ff0ab71c9
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index b91e709..e6bbe32 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -66,6 +66,11 @@ Required properties (DMA function blocks):
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Optional properties (RDMA function blocks):
> +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
mediatek,rdma-fifo-size
What's the range/set of valid values?
> + property to the corresponding rdma
> + the value is the Max value which defined in hardware data sheet.
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -207,3 +212,12 @@ od@14023000 {
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_DISP_OD>;
> };
> +
> +rdma1: rdma@1400c000 {
Does a new property really need a whole new example?
> + compatible = "mediatek,mt8183-disp-rdma";
> + reg = <0 0x1400c000 0 0x1000>;
> + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> + clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> + mediatek,rdma_fifo_size = <2048>;
> +};
> --
> 1.8.1.1.dirty
next prev parent reply other threads:[~2020-08-12 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 2:53 [RESEND v7, PATCH 0/7] add drm support for MT8183 Yongqiang Niu
2020-08-08 2:53 ` [RESEND v7, PATCH 1/7] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Yongqiang Niu
2020-08-09 0:56 ` Chun-Kuang Hu
2020-08-09 1:08 ` Chun-Kuang Hu
2020-08-12 16:55 ` Rob Herring [this message]
2020-08-08 2:53 ` [RESEND v7, PATCH 2/7] drm/mediatek: move ddp component define into mtk_mmsys.h Yongqiang Niu
2020-08-09 0:52 ` Chun-Kuang Hu
2020-08-08 2:53 ` [RESEND v7, PATCH 3/7] mtk-mmsys: add mmsys private data Yongqiang Niu
2020-08-10 23:35 ` Chun-Kuang Hu
2020-08-08 2:53 ` [RESEND v7, PATCH 4/7] mtk-mmsys: add mt8183 mmsys support Yongqiang Niu
2020-11-17 7:33 ` Hsin-Yi Wang
2020-08-08 2:53 ` [RESEND v7, PATCH 5/7] drm/mediatek: add fifo_size into rdma private data Yongqiang Niu
2020-08-08 2:53 ` [RESEND v7, PATCH 6/7] drm/mediatek: add support for mediatek SOC MT8183 Yongqiang Niu
2020-08-09 0:35 ` Chun-Kuang Hu
2020-08-08 2:53 ` [RESEND v7, PATCH 7/7] arm64: dts: add display nodes for mt8183 Yongqiang Niu
2020-08-09 0:36 ` [RESEND v7, PATCH 0/7] add drm support for MT8183 Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812165504.GA2361465@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).