From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F041BC433E1 for ; Thu, 13 Aug 2020 00:57:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2C5720774 for ; Thu, 13 Aug 2020 00:57:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726635AbgHMA5I (ORCPT ); Wed, 12 Aug 2020 20:57:08 -0400 Received: from mga09.intel.com ([134.134.136.24]:41031 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgHMA5G (ORCPT ); Wed, 12 Aug 2020 20:57:06 -0400 IronPort-SDR: NCuod2S6bSThmGeLoC6h9hcDHhOuUjs55lw8u6zB478IH5KgvDW8607u7E0WYYhERDPGza9Fum Ha+B6EtBgwkw== X-IronPort-AV: E=McAfee;i="6000,8403,9711"; a="155260395" X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="155260395" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2020 17:57:05 -0700 IronPort-SDR: d2IqxA7DPdzjHj7eRpAIFYkBVUysVrnxUHGAi94A268K5wmcLCe1wtj9jJg8L0F8a8I9QHnojn DZnhX0azhe3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,306,1592895600"; d="scan'208";a="495693428" Received: from lkp-server01.sh.intel.com (HELO 7f1ebb311643) ([10.239.97.150]) by fmsmga005.fm.intel.com with ESMTP; 12 Aug 2020 17:57:03 -0700 Received: from kbuild by 7f1ebb311643 with local (Exim 4.92) (envelope-from ) id 1k61YF-0000LS-73; Thu, 13 Aug 2020 00:57:03 +0000 Date: Thu, 13 Aug 2020 08:56:06 +0800 From: kernel test robot To: Denis Efremov Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Julia Lawall , "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org Subject: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings Message-ID: <20200813005606.GA84871@8851f5375e5a> References: <202008130840.TWLDLwLA%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008130840.TWLDLwLA%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot drivers/acpi/dock.c:563:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:544:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:495:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:506:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7c2a69f610e64c8dec6a06a66e721f4ce1dd783a commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script Please take the patch only if it's a positive warning. Thanks! dock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -492,7 +492,7 @@ static ssize_t show_docked(struct device struct acpi_device *adev = NULL; acpi_bus_get_device(dock_station->handle, &adev); - return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev)); + return scnprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev)); } static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL); @@ -503,7 +503,7 @@ static ssize_t show_flags(struct device struct device_attribute *attr, char *buf) { struct dock_station *dock_station = dev->platform_data; - return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags); + return scnprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags); } static DEVICE_ATTR(flags, S_IRUGO, show_flags, NULL); @@ -541,7 +541,7 @@ static ssize_t show_dock_uid(struct devi if (ACPI_FAILURE(status)) return 0; - return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf); + return scnprintf(buf, PAGE_SIZE, "%llx\n", lbuf); } static DEVICE_ATTR(uid, S_IRUGO, show_dock_uid, NULL); @@ -560,7 +560,7 @@ static ssize_t show_dock_type(struct dev else type = "unknown"; - return snprintf(buf, PAGE_SIZE, "%s\n", type); + return scnprintf(buf, PAGE_SIZE, "%s\n", type); } static DEVICE_ATTR(type, S_IRUGO, show_dock_type, NULL);