From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Balamuruhan S <bala24@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 1/2] perf bench numa: fix cpumask memory leak in node_has_cpus()
Date: Thu, 13 Aug 2020 17:36:49 +0530 [thread overview]
Message-ID: <20200813120649.GA21578@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200813113041.GA1685@oc3871087118.ibm.com>
* Alexander Gordeev <agordeev@linux.ibm.com> [2020-08-13 13:30:42]:
> Couple numa_allocate_cpumask() and numa_free_cpumask() functions
>
> Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
> ---
> tools/perf/bench/numa.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c
> index 31e2601..9066511 100644
> --- a/tools/perf/bench/numa.c
> +++ b/tools/perf/bench/numa.c
> @@ -248,16 +248,21 @@ static int is_node_present(int node)
> static bool node_has_cpus(int node)
> {
> struct bitmask *cpu = numa_allocate_cpumask();
> + bool ret = false; /* fall back to nocpus */
> unsigned int i;
>
> - if (cpu && !numa_node_to_cpus(node, cpu)) {
> + BUG_ON(!cpu);
> + if (!numa_node_to_cpus(node, cpu)) {
> for (i = 0; i < cpu->size; i++) {
> - if (numa_bitmask_isbitset(cpu, i))
> - return true;
> + if (numa_bitmask_isbitset(cpu, i)) {
> + ret = true;
> + break;
> + }
> }
> }
> + numa_free_cpumask(cpu);
>
> - return false; /* lets fall back to nocpus safely */
> + return ret;
> }
>
> static cpu_set_t bind_to_cpu(int target_cpu)
> --
> 1.8.3.1
>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2020-08-13 12:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 6:21 [PATCH v2 0/3] perf bench numa: make possible testing on uneven and/or overlapping CPU ranges Alexander Gordeev
2020-08-10 6:21 ` [PATCH v2 1/3] perf bench numa: use numa_node_to_cpus() to bind tasks to nodes Alexander Gordeev
2020-08-11 7:26 ` Namhyung Kim
2020-08-11 8:11 ` Alexander Gordeev
2020-08-13 11:30 ` [PATCH v3 1/2] perf bench numa: fix cpumask memory leak in node_has_cpus() Alexander Gordeev
2020-08-13 12:06 ` Srikar Dronamraju [this message]
2020-08-13 13:03 ` Arnaldo Carvalho de Melo
2020-08-13 11:32 ` [PATCH v3 1/2] perf bench numa: use numa_node_to_cpus() to bind tasks to nodes Alexander Gordeev
2020-08-13 12:07 ` Srikar Dronamraju
2020-08-13 13:03 ` Arnaldo Carvalho de Melo
2020-08-10 6:21 ` [PATCH v2 2/3] perf bench numa: fix number of processes in "2x3-convergence" test Alexander Gordeev
2020-08-11 7:27 ` Namhyung Kim
2020-08-12 12:07 ` Arnaldo Carvalho de Melo
2020-08-10 6:22 ` [PATCH v2 3/3] perf bench numa: fix benchmark names Alexander Gordeev
2020-08-12 12:09 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813120649.GA21578@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bala24@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sathnaga@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).