From: Ingo Molnar <mingo@kernel.org>
To: Libing Zhou <libing.zhou@nokia-sbell.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de
Subject: Re: [PATCH] sched: print fields name when do sched_show_task
Date: Thu, 13 Aug 2020 21:11:25 +0200 [thread overview]
Message-ID: <20200813191125.GA2337490@gmail.com> (raw)
In-Reply-To: <20200813104833.17573-1-libing.zhou@nokia-sbell.com>
* Libing Zhou <libing.zhou@nokia-sbell.com> wrote:
> Current sysrq(t) output task fields name are not aligned with
> actual task fields value, e.g.:
>
> kernel: sysrq: SysRq : Show State
> kernel: task PC stack pid father
> kernel: systemd S12456 1 0 0x00000000
> kernel: Call Trace:
> kernel: ? __schedule+0x240/0x740
>
> To make it more readable, print fields name together with task fields
> value in same line, remove separate fields name print.
Makes sense in principle, but could you please quote the new format as
well in the changelog, not just the old format? Makes it much easier
to compare.
Thanks,
Ingo
prev parent reply other threads:[~2020-08-13 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 10:48 [PATCH] sched: print fields name when do sched_show_task Libing Zhou
2020-08-13 19:11 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813191125.GA2337490@gmail.com \
--to=mingo@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=libing.zhou@nokia-sbell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).