From: David Miller <davem@davemloft.net>
To: fazilyildiran@gmail.com
Cc: kuba@kernel.org, courtney.cavin@sonymobile.com,
bjorn.andersson@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dvyukov@google.com,
elver@google.com, andreyknvl@google.com, glider@google.com,
necip@google.com,
syzbot+f31428628ef672716ea8@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: qrtr: fix usage of idr in port assignment to socket
Date: Fri, 14 Aug 2020 13:55:26 -0700 (PDT) [thread overview]
Message-ID: <20200814.135526.430805159179452727.davem@davemloft.net> (raw)
In-Reply-To: <20200814101000.2463612-1-fazilyildiran@gmail.com>
From: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Date: Fri, 14 Aug 2020 10:10:00 +0000
> diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
> index b4c0db0b7d31..52d0707df776 100644
> --- a/net/qrtr/qrtr.c
> +++ b/net/qrtr/qrtr.c
> @@ -693,22 +693,24 @@ static void qrtr_port_remove(struct qrtr_sock *ipc)
> static int qrtr_port_assign(struct qrtr_sock *ipc, int *port)
> {
> int rc;
> + u32 min_port;
Please use reverse christmas tree ordering for local variables.
next prev parent reply other threads:[~2020-08-14 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 10:10 [PATCH] net: qrtr: fix usage of idr in port assignment to socket Necip Fazil Yildiran
2020-08-14 20:55 ` David Miller [this message]
2020-08-16 15:36 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814.135526.430805159179452727.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreyknvl@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=courtney.cavin@sonymobile.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=fazilyildiran@gmail.com \
--cc=glider@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=necip@google.com \
--cc=netdev@vger.kernel.org \
--cc=syzbot+f31428628ef672716ea8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).