From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 426B9C433E1 for ; Fri, 14 Aug 2020 16:37:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C50E2074D for ; Fri, 14 Aug 2020 16:37:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="H25HU0x0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727890AbgHNQh1 (ORCPT ); Fri, 14 Aug 2020 12:37:27 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:49651 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgHNQhX (ORCPT ); Fri, 14 Aug 2020 12:37:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597423043; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=4xiBrWPGNBnaNNIAe493itARuZ6OD6wP68Tooso72rw=; b=H25HU0x05F3LYs6q8co46Pg2ryfOomRtYZiJEvcQ0Dx7Q6FOcSUuSRwXz2YTU+OzT6QXA1Mp FLWUCcd/CrgC1wzGxwiukrqyQ+y6QnXm4f40zgc7g+jnYWpzTkZyuNg+iwbbF6C+1xT6GWoz ex5xLf7SE5PatVEBHogE7Q1mqow= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f36bdbaba4c2cd367fe044a (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 14 Aug 2020 16:37:14 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E8464C433B1; Fri, 14 Aug 2020 16:37:12 +0000 (UTC) Received: from asutoshd-linux1.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: asutoshd) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6E414C433CA; Fri, 14 Aug 2020 16:37:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6E414C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=asutoshd@codeaurora.org Date: Fri, 14 Aug 2020 09:37:04 -0700 From: Asutosh Das To: Bean Huo Cc: alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, stanley.chu@mediatek.com, beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com, cang@codeaurora.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu() Message-ID: <20200814163704.GA1217@asutoshd-linux1.qualcomm.com> References: <20200814095034.20709-1-huobean@gmail.com> <20200814095034.20709-2-huobean@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200814095034.20709-2-huobean@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 14 2020 at 02:50 -0700, Bean Huo wrote: >From: Bean Huo > >ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request >completion calling function. Change it to ufshcd_compose_devman_upiu(). > >Signed-off-by: Bean Huo >Acked-by: Avri Altman >--- Reviewed-by: Asutosh Das > drivers/scsi/ufs/ufshcd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c >index 5f09cda7b21c..e3663b85e8ee 100644 >--- a/drivers/scsi/ufs/ufshcd.c >+++ b/drivers/scsi/ufs/ufshcd.c >@@ -2391,12 +2391,13 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp) > } > > /** >- * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU) >+ * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU) > * for Device Management Purposes > * @hba: per adapter instance > * @lrbp: pointer to local reference block > */ >-static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) >+static int ufshcd_compose_devman_upiu(struct ufs_hba *hba, >+ struct ufshcd_lrb *lrbp) > { > u8 upiu_flags; > int ret = 0; >@@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba *hba, > ufshcd_prepare_lrbp_crypto(NULL, lrbp); > hba->dev_cmd.type = cmd_type; > >- return ufshcd_comp_devman_upiu(hba, lrbp); >+ return ufshcd_compose_devman_upiu(hba, lrbp); > } > > static int >-- >2.17.1 >