linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform: cros_ec: Add fields to command traces
@ 2020-08-15  3:39 Gwendal Grignou
  2020-08-26 15:23 ` Raul Rangel
  2020-09-01  9:10 ` Enric Balletbo i Serra
  0 siblings, 2 replies; 3+ messages in thread
From: Gwendal Grignou @ 2020-08-15  3:39 UTC (permalink / raw)
  To: rrangel, enric.balletbo, groeck; +Cc: linux-kernel, Gwendal Grignou

In ftrace, add more fields to the cros_ec command event:
- Add size of commands to check if they are properly set.
- Add offset (in case an EC is cascaded being another EC),
to allow proper command output

With:
echo 1 > events/cros_ec/cros_ec_cmd/enable
We now have (on samus)

invalid command for the sensor stack:
ectool-6942  [002] ....  3082.783116: cros_ec_request_done: version: 3,
 offset: 0, command: EC_CMD_MOTION_SENSE_CMD, outsize: 2, insize: 19,
 ec result: EC_RES_INVALID_PARAM, retval: 0

powerd accessing PD EC being the main EC:
powerd-1272  [002] ....    40.644026: cros_ec_request_done: version: 0,
 offset: 1, command: EC_CMD_USB_PD_POWER_INFO, outsize: 1, insize: 16,
 ec result: EC_RES_SUCCESS, retval: 16

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
 drivers/platform/chrome/cros_ec_trace.h | 27 +++++++++++++++++++------
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
index e9fb05f89ef07..f744b21bc655f 100644
--- a/drivers/platform/chrome/cros_ec_trace.h
+++ b/drivers/platform/chrome/cros_ec_trace.h
@@ -23,14 +23,22 @@ TRACE_EVENT(cros_ec_request_start,
 	TP_ARGS(cmd),
 	TP_STRUCT__entry(
 		__field(uint32_t, version)
+		__field(uint32_t, offset)
 		__field(uint32_t, command)
+		__field(uint32_t, outsize)
+		__field(uint32_t, insize)
 	),
 	TP_fast_assign(
 		__entry->version = cmd->version;
-		__entry->command = cmd->command;
+		__entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(1);
+		__entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(1);
+		__entry->outsize = cmd->outsize;
+		__entry->insize = cmd->insize;
 	),
-	TP_printk("version: %u, command: %s", __entry->version,
-		  __print_symbolic(__entry->command, EC_CMDS))
+	TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
+		  __entry->version, __entry->offset,
+		  __print_symbolic(__entry->command, EC_CMDS),
+		  __entry->outsize, __entry->insize)
 );
 
 TRACE_EVENT(cros_ec_request_done,
@@ -38,19 +46,26 @@ TRACE_EVENT(cros_ec_request_done,
 	TP_ARGS(cmd, retval),
 	TP_STRUCT__entry(
 		__field(uint32_t, version)
+		__field(uint32_t, offset)
 		__field(uint32_t, command)
+		__field(uint32_t, outsize)
+		__field(uint32_t, insize)
 		__field(uint32_t, result)
 		__field(int, retval)
 	),
 	TP_fast_assign(
 		__entry->version = cmd->version;
-		__entry->command = cmd->command;
+		__entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(1);
+		__entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(1);
+		__entry->outsize = cmd->outsize;
+		__entry->insize = cmd->insize;
 		__entry->result = cmd->result;
 		__entry->retval = retval;
 	),
-	TP_printk("version: %u, command: %s, ec result: %s, retval: %d",
-		  __entry->version,
+	TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u, ec result: %s, retval: %u",
+		  __entry->version, __entry->offset,
 		  __print_symbolic(__entry->command, EC_CMDS),
+		  __entry->outsize, __entry->insize,
 		  __print_symbolic(__entry->result, EC_RESULT),
 		  __entry->retval)
 );
-- 
2.28.0.220.ged08abb693-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] platform: cros_ec: Add fields to command traces
  2020-08-15  3:39 [PATCH] platform: cros_ec: Add fields to command traces Gwendal Grignou
@ 2020-08-26 15:23 ` Raul Rangel
  2020-09-01  9:10 ` Enric Balletbo i Serra
  1 sibling, 0 replies; 3+ messages in thread
From: Raul Rangel @ 2020-08-26 15:23 UTC (permalink / raw)
  To: Gwendal Grignou; +Cc: Enric Balletbo i Serra, Guenter Roeck, linux-kernel

On Fri, Aug 14, 2020 at 9:39 PM Gwendal Grignou <gwendal@chromium.org> wrote:
>
> In ftrace, add more fields to the cros_ec command event:
> - Add size of commands to check if they are properly set.
> - Add offset (in case an EC is cascaded being another EC),
> to allow proper command output
>
> With:
> echo 1 > events/cros_ec/cros_ec_cmd/enable
> We now have (on samus)
>
> invalid command for the sensor stack:
> ectool-6942  [002] ....  3082.783116: cros_ec_request_done: version: 3,
>  offset: 0, command: EC_CMD_MOTION_SENSE_CMD, outsize: 2, insize: 19,
>  ec result: EC_RES_INVALID_PARAM, retval: 0
>
> powerd accessing PD EC being the main EC:
> powerd-1272  [002] ....    40.644026: cros_ec_request_done: version: 0,
>  offset: 1, command: EC_CMD_USB_PD_POWER_INFO, outsize: 1, insize: 16,
>  ec result: EC_RES_SUCCESS, retval: 16
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Acked-by: Raul E Rangel <rrangel@chromium.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] platform: cros_ec: Add fields to command traces
  2020-08-15  3:39 [PATCH] platform: cros_ec: Add fields to command traces Gwendal Grignou
  2020-08-26 15:23 ` Raul Rangel
@ 2020-09-01  9:10 ` Enric Balletbo i Serra
  1 sibling, 0 replies; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-09-01  9:10 UTC (permalink / raw)
  To: Gwendal Grignou, rrangel, groeck; +Cc: linux-kernel

Hi Gwendal,

On 15/8/20 5:39, Gwendal Grignou wrote:
> In ftrace, add more fields to the cros_ec command event:
> - Add size of commands to check if they are properly set.
> - Add offset (in case an EC is cascaded being another EC),
> to allow proper command output
> 
> With:
> echo 1 > events/cros_ec/cros_ec_cmd/enable
> We now have (on samus)
> 
> invalid command for the sensor stack:
> ectool-6942  [002] ....  3082.783116: cros_ec_request_done: version: 3,
>  offset: 0, command: EC_CMD_MOTION_SENSE_CMD, outsize: 2, insize: 19,
>  ec result: EC_RES_INVALID_PARAM, retval: 0
> 
> powerd accessing PD EC being the main EC:
> powerd-1272  [002] ....    40.644026: cros_ec_request_done: version: 0,
>  offset: 1, command: EC_CMD_USB_PD_POWER_INFO, outsize: 1, insize: 16,
>  ec result: EC_RES_SUCCESS, retval: 16
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---

Applied for 5.10.

Thanks,
 Enric


>  drivers/platform/chrome/cros_ec_trace.h | 27 +++++++++++++++++++------
>  1 file changed, 21 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_trace.h b/drivers/platform/chrome/cros_ec_trace.h
> index e9fb05f89ef07..f744b21bc655f 100644
> --- a/drivers/platform/chrome/cros_ec_trace.h
> +++ b/drivers/platform/chrome/cros_ec_trace.h
> @@ -23,14 +23,22 @@ TRACE_EVENT(cros_ec_request_start,
>  	TP_ARGS(cmd),
>  	TP_STRUCT__entry(
>  		__field(uint32_t, version)
> +		__field(uint32_t, offset)
>  		__field(uint32_t, command)
> +		__field(uint32_t, outsize)
> +		__field(uint32_t, insize)
>  	),
>  	TP_fast_assign(
>  		__entry->version = cmd->version;
> -		__entry->command = cmd->command;
> +		__entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(1);
> +		__entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(1);
> +		__entry->outsize = cmd->outsize;
> +		__entry->insize = cmd->insize;
>  	),
> -	TP_printk("version: %u, command: %s", __entry->version,
> -		  __print_symbolic(__entry->command, EC_CMDS))
> +	TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
> +		  __entry->version, __entry->offset,
> +		  __print_symbolic(__entry->command, EC_CMDS),
> +		  __entry->outsize, __entry->insize)
>  );
>  
>  TRACE_EVENT(cros_ec_request_done,
> @@ -38,19 +46,26 @@ TRACE_EVENT(cros_ec_request_done,
>  	TP_ARGS(cmd, retval),
>  	TP_STRUCT__entry(
>  		__field(uint32_t, version)
> +		__field(uint32_t, offset)
>  		__field(uint32_t, command)
> +		__field(uint32_t, outsize)
> +		__field(uint32_t, insize)
>  		__field(uint32_t, result)
>  		__field(int, retval)
>  	),
>  	TP_fast_assign(
>  		__entry->version = cmd->version;
> -		__entry->command = cmd->command;
> +		__entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(1);
> +		__entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(1);
> +		__entry->outsize = cmd->outsize;
> +		__entry->insize = cmd->insize;
>  		__entry->result = cmd->result;
>  		__entry->retval = retval;
>  	),
> -	TP_printk("version: %u, command: %s, ec result: %s, retval: %d",
> -		  __entry->version,
> +	TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u, ec result: %s, retval: %u",
> +		  __entry->version, __entry->offset,
>  		  __print_symbolic(__entry->command, EC_CMDS),
> +		  __entry->outsize, __entry->insize,
>  		  __print_symbolic(__entry->result, EC_RESULT),
>  		  __entry->retval)
>  );
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-01  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15  3:39 [PATCH] platform: cros_ec: Add fields to command traces Gwendal Grignou
2020-08-26 15:23 ` Raul Rangel
2020-09-01  9:10 ` Enric Balletbo i Serra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).