archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] usb: renesas-xhci: add missing versions
@ 2020-08-16 11:59 Vinod Koul
  0 siblings, 0 replies; only message in thread
From: Vinod Koul @ 2020-08-16 11:59 UTC (permalink / raw)
  To: Mathias Nyman, Greg Kroah-Hartman; +Cc: Vinod Koul, linux-usb, linux-kernel

Some devices in wild are reporting firmware version as 0x2011 and
0x2020, so add these as well

Reported by: Anastasios Vacharakis <>
Reported by: Glen Journeay <>
Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201")
Signed-off-by: Vinod Koul <>
Greg, this fixes regression for folks with preprogrammed controllers with
firmware version 0x2020 and 0x2011, please mark as stable material

 drivers/usb/host/xhci-pci-renesas.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci-pci-renesas.c b/drivers/usb/host/xhci-pci-renesas.c
index 59b1965ad0a3..f32b5a958ace 100644
--- a/drivers/usb/host/xhci-pci-renesas.c
+++ b/drivers/usb/host/xhci-pci-renesas.c
@@ -50,14 +50,19 @@
 #define RENESAS_RETRY	10000
 #define RENESAS_DELAY	10
-#define ROM_VALID_01 0x2013
-#define ROM_VALID_02 0x2026
+/* keep the ids sorted */
+#define ROM_VALID_01 0x2011
+#define ROM_VALID_02 0x2013
+#define ROM_VALID_03 0x2020
+#define ROM_VALID_04 0x2026
 static int renesas_verify_fw_version(struct pci_dev *pdev, u32 version)
 	switch (version) {
 	case ROM_VALID_01:
 	case ROM_VALID_02:
+	case ROM_VALID_03:
+	case ROM_VALID_04:
 		return 0;
 	dev_err(&pdev->dev, "FW has invalid version :%d\n", version);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-08-16 12:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16 11:59 [PATCH v2] usb: renesas-xhci: add missing versions Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).