From: Sam Ravnborg <sam@ravnborg.org>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Paul Mackerras <paulus@samba.org>,
Russell King <linux@armlinux.org.uk>,
Andres Salomon <dilinger@queued.net>,
Antonino Daplas <adaplas@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-geode@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management
Date: Sun, 16 Aug 2020 22:24:42 +0200 [thread overview]
Message-ID: <20200816202442.GB1426650@ravnborg.org> (raw)
In-Reply-To: <20200810185723.15540-10-vaibhavgupta40@gmail.com>
Hi Vaibhav
On Tue, Aug 11, 2020 at 12:27:20AM +0530, Vaibhav Gupta wrote:
> Drivers should do only device-specific jobs. But in general, drivers using
> legacy PCI PM framework for .suspend()/.resume() have to manage many PCI
> PM-related tasks themselves which can be done by PCI Core itself. This
> brings extra load on the driver and it directly calls PCI helper functions
> to handle them.
>
> Switch to the new generic framework by updating function signatures and
> define a "struct dev_pm_ops" variable to bind PM callbacks. Also, remove
> unnecessary calls to the PCI Helper functions along with the legacy
> .suspend & .resume bindings.
>
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
I several of the drivers I briefly looked at a new set of helpers were
introduced for the different types of pm actions.
They then called a more generic function that uses the passes
enumeration to decide what to do.
But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped
and there is no freeze operation.
Please explain this change so the reader is not left wondering.
Sam
> ---
> drivers/video/fbdev/i740fb.c | 40 +++++++++++++++---------------------
> 1 file changed, 16 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c
> index c65ec7386e87..8d7f06fc8a5a 100644
> --- a/drivers/video/fbdev/i740fb.c
> +++ b/drivers/video/fbdev/i740fb.c
> @@ -1175,16 +1175,11 @@ static void i740fb_remove(struct pci_dev *dev)
> }
> }
>
> -#ifdef CONFIG_PM
> -static int i740fb_suspend(struct pci_dev *dev, pm_message_t state)
> +static int __maybe_unused i740fb_suspend(struct device *dev)
> {
> - struct fb_info *info = pci_get_drvdata(dev);
> + struct fb_info *info = dev_get_drvdata(dev);
> struct i740fb_par *par = info->par;
>
> - /* don't disable console during hibernation and wakeup from it */
> - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW)
> - return 0;
> -
> console_lock();
> mutex_lock(&(par->open_lock));
>
> @@ -1197,19 +1192,15 @@ static int i740fb_suspend(struct pci_dev *dev, pm_message_t state)
>
> fb_set_suspend(info, 1);
>
> - pci_save_state(dev);
> - pci_disable_device(dev);
> - pci_set_power_state(dev, pci_choose_state(dev, state));
> -
> mutex_unlock(&(par->open_lock));
> console_unlock();
>
> return 0;
> }
>
> -static int i740fb_resume(struct pci_dev *dev)
> +static int __maybe_unused i740fb_resume(struct device *dev)
> {
> - struct fb_info *info = pci_get_drvdata(dev);
> + struct fb_info *info = dev_get_drvdata(dev);
> struct i740fb_par *par = info->par;
>
> console_lock();
> @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev)
> if (par->ref_count == 0)
> goto fail;
>
> - pci_set_power_state(dev, PCI_D0);
> - pci_restore_state(dev);
> - if (pci_enable_device(dev))
> - goto fail;
> -
> i740fb_set_par(info);
> fb_set_suspend(info, 0);
>
> @@ -1231,10 +1217,17 @@ static int i740fb_resume(struct pci_dev *dev)
> console_unlock();
> return 0;
> }
> -#else
> -#define i740fb_suspend NULL
> -#define i740fb_resume NULL
> -#endif /* CONFIG_PM */
> +
> +static const struct dev_pm_ops i740fb_pm_ops = {
> +#ifdef CONFIG_PM_SLEEP
> + .suspend = i740fb_suspend,
> + .resume = i740fb_resume,
> + .freeze = NULL,
> + .thaw = i740fb_resume,
> + .poweroff = i740fb_suspend,
> + .restore = i740fb_resume,
> +#endif /* CONFIG_PM_SLEEP */
> +};
>
> #define I740_ID_PCI 0x00d1
> #define I740_ID_AGP 0x7800
> @@ -1251,8 +1244,7 @@ static struct pci_driver i740fb_driver = {
> .id_table = i740fb_id_table,
> .probe = i740fb_probe,
> .remove = i740fb_remove,
> - .suspend = i740fb_suspend,
> - .resume = i740fb_resume,
> + .driver.pm = &i740fb_pm_ops,
> };
>
> #ifndef MODULE
> --
> 2.27.0
next prev parent reply other threads:[~2020-08-16 20:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 18:07 [PATCH v1 00/12] video: fbdev: use generic power management Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 01/12] fbdev: gxfb: " Vaibhav Gupta
2020-08-05 20:19 ` Bjorn Helgaas
2020-08-06 5:59 ` Vaibhav Gupta
2020-08-08 11:17 ` Sam Ravnborg
2020-08-10 9:39 ` Vaibhav Gupta
2020-08-10 9:44 ` Vaibhav Gupta
2020-08-10 16:54 ` Sam Ravnborg
2020-08-10 17:58 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 00/12] video: fbdev: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 01/12] fbdev: gxfb: " Vaibhav Gupta
2020-08-16 20:16 ` Sam Ravnborg
2020-08-17 7:45 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 02/12] fbdev: lxfb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 03/12] fbdev: via-core: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 04/12] fbdev: aty: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 05/12] fbdev: aty128fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 06/12] fbdev: nvidia: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 07/12] fbdev: savagefb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 08/12] fbdev: cyber2000fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 09/12] fbdev: i740fb: " Vaibhav Gupta
2020-08-16 20:24 ` Sam Ravnborg [this message]
2020-08-17 7:46 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 10/12] fbdev: vt8623fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 11/12] fbdev: s3fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 12/12] fbdev: arkfb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 02/12] fbdev: lxfb: " Vaibhav Gupta
2020-08-08 11:19 ` Sam Ravnborg
2020-08-05 18:07 ` [PATCH v1 03/12] fbdev: via-core: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 04/12] fbdev: aty: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 05/12] fbdev: aty128fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 06/12] fbdev: nvidia: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 07/12] fbdev: savagefb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 08/12] fbdev: cyber2000fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 09/12] fbdev: i740fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 10/12] fbdev: vt8623fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 11/12] fbdev: s3fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 12/12] fbdev: arkfb: " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816202442.GB1426650@ravnborg.org \
--to=sam@ravnborg.org \
--cc=adaplas@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=bhelgaas@google.com \
--cc=bjorn@helgaas.com \
--cc=dilinger@queued.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=paulus@samba.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).