From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC08C433E3 for ; Mon, 17 Aug 2020 18:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9303320758 for ; Mon, 17 Aug 2020 18:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597687859; bh=zfTbdVOfDIBpKELnc64oGWyDb5AwND2CYHOdFudtnok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=F7v5I3DujmpllaTQFt+65pelCi7JGhCAyE0aSk2NH6A7S2aY3Kh0JiHgOTPTJeLTM rVQ7p2dM+my88MskrgFRi+L3PTyAClgFCh4R3Uhm4lce3v53aaRdK4KyitMkG8fGUO 6MSSdweaYBtJ5JR14hRcUmj+QE3JwGxxCeeFAbO4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390438AbgHQSK5 (ORCPT ); Mon, 17 Aug 2020 14:10:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:55818 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388417AbgHQQHd (ORCPT ); Mon, 17 Aug 2020 12:07:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E9EF207FB; Mon, 17 Aug 2020 16:07:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597680452; bh=zfTbdVOfDIBpKELnc64oGWyDb5AwND2CYHOdFudtnok=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KxjAilEjdh2WdyYla+hfIBpDPZbTGNL2GQo5lYc3ET4zkyQwrg+tyxEsYWGMbHITx jzFZ/7H6G+JoLIsaBfZH7BeVQrgWZrD1JROaGAPQn9O8WgVUoXEqtVElp90Jy2yL3I 5Re1lV7DrkaVEAd6Y9zi8EJZL+X74MICpIssM+o8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yu Kuai , Thomas Bogendoerfer , Sasha Levin Subject: [PATCH 5.4 162/270] MIPS: OCTEON: add missing put_device() call in dwc3_octeon_device_init() Date: Mon, 17 Aug 2020 17:16:03 +0200 Message-Id: <20200817143803.909019208@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143755.807583758@linuxfoundation.org> References: <20200817143755.807583758@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Kuai [ Upstream commit e8b9fc10f2615b9a525fce56981e40b489528355 ] if of_find_device_by_node() succeed, dwc3_octeon_device_init() doesn't have a corresponding put_device(). Thus add put_device() to fix the exception handling for this function implementation. Fixes: 93e502b3c2d4 ("MIPS: OCTEON: Platform support for OCTEON III USB controller") Signed-off-by: Yu Kuai Signed-off-by: Thomas Bogendoerfer Signed-off-by: Sasha Levin --- arch/mips/cavium-octeon/octeon-usb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c index cc88a08bc1f73..4017398519cf9 100644 --- a/arch/mips/cavium-octeon/octeon-usb.c +++ b/arch/mips/cavium-octeon/octeon-usb.c @@ -518,6 +518,7 @@ static int __init dwc3_octeon_device_init(void) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (res == NULL) { + put_device(&pdev->dev); dev_err(&pdev->dev, "No memory resources\n"); return -ENXIO; } @@ -529,8 +530,10 @@ static int __init dwc3_octeon_device_init(void) * know the difference. */ base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(base)) + if (IS_ERR(base)) { + put_device(&pdev->dev); return PTR_ERR(base); + } mutex_lock(&dwc3_octeon_clocks_mutex); dwc3_octeon_clocks_start(&pdev->dev, (u64)base); -- 2.25.1