From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
James Clark <james.clark@arm.com>, Will Deacon <will@kernel.org>,
Al Grant <Al.Grant@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Wei Li <liwei391@huawei.com>,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH RESEND v1 00/13] perf arm-spe: Refactor decoding & dumping flow
Date: Mon, 17 Aug 2020 15:53:35 +0100 [thread overview]
Message-ID: <20200817145348.14461-1-leo.yan@linaro.org> (raw)
The prominent issue for the SPE trace decoding and dumping is the packet
header and payload values are hard coded with numbers and it's not
readable and difficult to maintain; and has other minor issues, e.g. the
packet length (header + payload) calculation is not correct for some
packet types, and the dumping flow misses to support specific sub
classes for operation packet, etc.
So this patch set is to refactor the Arm SPE decoding SPE with:
- Patches 01, 02 are minor cleans up;
- Patches 03, 04 are used to fix and polish the packet and payload
length calculation;
- Patches 05 ~ 12 are used to refactor decoding for different types
packet one by one (address packet, context packet, counter packet,
event packet, operation packet);
- Patch 13 is coming from Wei Li to add decoding for ARMv8.3
extension, in this version it has been improved to use defined
macros, also is improved for failure handling and commit log.
Prerequisite: This patch set is applied on the top of perf/core branch
with commit 492e4edba6e2 ("perf ftrace: Make option description initials
all capital letters"), and also it relies on Wei Li's bug fixing patch
"perf: arm-spe: Fix check error when synthesizing events" [1].
This patch set has been verified on Hisilicon D06 platform.
[1] https://lkml.org/lkml/2020/7/24/132
Sigh, the patch set failed to send out caused by my networking
connection, resend it. Sorry for spamming and inconvinence.
Leo Yan (12):
perf arm-spe: Include bitops.h for BIT() macro
perf arm-spe: Fix a typo in comment
perf arm-spe: Refactor payload length calculation
perf arm-spe: Fix packet length handling
perf arm-spe: Refactor packet header parsing
perf arm-spe: Refactor address packet handling
perf arm-spe: Refactor context packet handling
perf arm-spe: Refactor counter packet handling
perf arm-spe: Refactor event type handling
perf arm-spe: Detect failure for snprintf()
perf arm-spe: Refactor operation packet handling
perf arm-spe: Add more sub classes for operation packet
Wei Li (1):
perf arm-spe: Add support for ARMv8.3-SPE
.../util/arm-spe-decoder/arm-spe-decoder.c | 54 ++-
.../util/arm-spe-decoder/arm-spe-decoder.h | 17 -
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 433 ++++++++++++------
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 117 ++++-
4 files changed, 418 insertions(+), 203 deletions(-)
--
2.17.1
next reply other threads:[~2020-08-17 14:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:53 Leo Yan [this message]
2020-08-17 14:53 ` [PATCH RESEND v1 01/13] perf arm-spe: Include bitops.h for BIT() macro Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 02/13] perf arm-spe: Fix a typo in comment Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 03/13] perf arm-spe: Refactor payload length calculation Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 04/13] perf arm-spe: Fix packet length handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 05/13] perf arm-spe: Refactor packet header parsing Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 06/13] perf arm-spe: Refactor address packet handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 07/13] perf arm-spe: Refactor context " Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 08/13] perf arm-spe: Refactor counter " Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 09/13] perf arm-spe: Refactor event type handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 10/13] perf arm-spe: Detect failure for snprintf() Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 11/13] perf arm-spe: Refactor operation packet handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 12/13] perf arm-spe: Add more sub classes for operation packet Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 13/13] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817145348.14461-1-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=Al.Grant@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).