From: Feng Tang <feng.tang@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: kernel test robot <rong.a.chen@intel.com>,
Tony Luck <tony.luck@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org
Subject: Re: [LKP] Re: [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression
Date: Tue, 18 Aug 2020 16:29:43 +0800 [thread overview]
Message-ID: <20200818082943.GA65567@shbuild999.sh.intel.com> (raw)
In-Reply-To: <20200425130136.GA28245@zn.tnic>
Hi Borislav,
On Sat, Apr 25, 2020 at 03:01:36PM +0200, Borislav Petkov wrote:
> On Sat, Apr 25, 2020 at 07:44:14PM +0800, kernel test robot wrote:
> > Greeting,
> >
> > FYI, we noticed a -14.1% regression of will-it-scale.per_process_ops due to commit:
> >
> >
> > commit: 1de08dccd383482a3e88845d3554094d338f5ff9 ("x86/mce: Add a struct mce.kflags field")
>
> I don't see how a struct mce member addition will cause any performance
> regression. Please check your test case.
Sorry for the late response.
We've done more rounds of test, and the test results are consistent.
Our suspect is the commit changes the data alignment of other kernel
domains than mce, which causes the performance change to this malloc
microbenchmark.
Without the patch, size of 'struct mce' is 120 bytes, while it will
be 128 bytes after adding the '__u64 kflags'
And we also debugged further:
* add "mce=off" to kernel cmdline, the performance change keeps.
* change the 'kflags' from __u64 to __u32 (the size of mce will
go back to 120 bytes), the performance change is gone
* only comment off '__u64 kflags', peformance change is gone.
We also tried perf c2c tool to capture some data, but the platform
is a Xeon Phi which doesn't support it. Capturing raw HITM event
also can not provide useful data.
0day has reported quite some strange peformance bump like this,
https://lore.kernel.org/lkml/20200205123216.GO12867@shao2-debian/
https://lore.kernel.org/lkml/20200114085637.GA29297@shao2-debian/
https://lore.kernel.org/lkml/20200330011254.GA14393@feng-iot/
for some of which, the bump could be gone if we hack to force all
kernel functions to be aligned, but it doesn't work for this case.
So together with the debugging above, we thought this could be a
data alignment change caused performance bump.
Thanks,
Feng
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg
> _______________________________________________
> LKP mailing list -- lkp@lists.01.org
> To unsubscribe send an email to lkp-leave@lists.01.org
next prev parent reply other threads:[~2020-08-18 8:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 11:44 [x86/mce] 1de08dccd3: will-it-scale.per_process_ops -14.1% regression kernel test robot
2020-04-25 13:01 ` Borislav Petkov
2020-08-18 8:29 ` Feng Tang [this message]
2020-08-18 20:06 ` [LKP] " Luck, Tony
2020-08-19 2:04 ` Feng Tang
2020-08-19 2:23 ` Luck, Tony
2020-08-19 3:04 ` Feng Tang
2020-08-19 3:15 ` Feng Tang
2020-08-21 2:02 ` Feng Tang
2020-08-24 15:14 ` Borislav Petkov
2020-08-24 15:33 ` Feng Tang
2020-08-24 15:38 ` Luck, Tony
2020-08-24 15:48 ` Feng Tang
2020-08-24 16:12 ` Borislav Petkov
2020-08-24 16:56 ` Mel Gorman
2020-08-25 6:49 ` Feng Tang
2020-08-25 6:23 ` Feng Tang
2020-08-25 16:44 ` Luck, Tony
2020-08-26 1:45 ` Feng Tang
2020-08-28 17:48 ` Borislav Petkov
2020-08-31 2:16 ` Feng Tang
2020-08-31 7:56 ` Mel Gorman
2020-08-31 8:23 ` Feng Tang
2020-08-31 8:55 ` Mel Gorman
2020-08-31 12:53 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818082943.GA65567@shbuild999.sh.intel.com \
--to=feng.tang@intel.com \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@lists.01.org \
--cc=rong.a.chen@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).