From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: <linux-mm@kvack.org>, <linux-arm-kernel@lists.infradead.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<akpm@linux-foundation.org>, Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
"Suzuki Poulose" <suzuki.poulose@arm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics
Date: Tue, 18 Aug 2020 13:26:25 +0100 [thread overview]
Message-ID: <20200818132625.00003d05@Huawei.com> (raw)
In-Reply-To: <8db455b6-8fe5-b552-119f-4abab0cc8501@arm.com>
On Tue, 18 Aug 2020 15:11:58 +0530
Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> On 08/18/2020 02:43 PM, Jonathan Cameron wrote:
> > On Mon, 17 Aug 2020 14:49:43 +0530
> > Anshuman Khandual <anshuman.khandual@arm.com> wrote:
> >
> >> pmd_present() and pmd_trans_huge() are expected to behave in the following
> >> manner during various phases of a given PMD. It is derived from a previous
> >> detailed discussion on this topic [1] and present THP documentation [2].
> >>
> >> pmd_present(pmd):
> >>
> >> - Returns true if pmd refers to system RAM with a valid pmd_page(pmd)
> >> - Returns false if pmd does not refer to system RAM - Invalid pmd_page(pmd)
> >>
> >> pmd_trans_huge(pmd):
> >>
> >> - Returns true if pmd refers to system RAM and is a trans huge mapping
> >>
> >> -------------------------------------------------------------------------
> >> | PMD states | pmd_present | pmd_trans_huge |
> >> -------------------------------------------------------------------------
> >> | Mapped | Yes | Yes |
> >> -------------------------------------------------------------------------
> >> | Splitting | Yes | Yes |
> >> -------------------------------------------------------------------------
> >> | Migration/Swap | No | No |
> >> -------------------------------------------------------------------------
> >>
> >> The problem:
> >>
> >> PMD is first invalidated with pmdp_invalidate() before it's splitting. This
> >> invalidation clears PMD_SECT_VALID as below.
> >>
> >> PMD Split -> pmdp_invalidate() -> pmd_mkinvalid -> Clears PMD_SECT_VALID
> >>
> >> Once PMD_SECT_VALID gets cleared, it results in pmd_present() return false
> >> on the PMD entry. It will need another bit apart from PMD_SECT_VALID to re-
> >> affirm pmd_present() as true during the THP split process. To comply with
> >> above mentioned semantics, pmd_trans_huge() should also check pmd_present()
> >> first before testing presence of an actual transparent huge mapping.
> >>
> >> The solution:
> >>
> >> Ideally PMD_TYPE_SECT should have been used here instead. But it shares the
> >> bit position with PMD_SECT_VALID which is used for THP invalidation. Hence
> >> it will not be there for pmd_present() check after pmdp_invalidate().
> >>
> >> A new software defined PMD_PRESENT_INVALID (bit 59) can be set on the PMD
> >> entry during invalidation which can help pmd_present() return true and in
> >> recognizing the fact that it still points to memory.
> >>
> >> This bit is transient. During the split process it will be overridden by a
> >> page table page representing normal pages in place of erstwhile huge page.
> >> Other pmdp_invalidate() callers always write a fresh PMD value on the entry
> >> overriding this transient PMD_PRESENT_INVALID bit, which makes it safe.
> >>
> >> [1]: https://lkml.org/lkml/2018/10/17/231
> >> [2]: https://www.kernel.org/doc/Documentation/vm/transhuge.txt
> >
> > Hi Anshuman,
> >
> > One query on this. From my reading of the ARM ARM, bit 59 is not
> > an ignored bit. The exact requirements for hardware to be using
> > it are a bit complex though.
> >
> > It 'might' be safe to use it for this, but if so can we have a comment
> > explaining why. Also more than possible I'm misunderstanding things!
>
> We are using this bit 59 only when the entry is not active from MMU
> perspective i.e PMD_SECT_VALID is clear.
>
Understood. I guess we ran out of bits that were always ignored so had
to start using ones that are ignored in this particular state.
Jonathan
next prev parent reply other threads:[~2020-08-18 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:19 [PATCH 0/2] arm64/mm: Enable THP migration Anshuman Khandual
2020-08-17 9:19 ` [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics Anshuman Khandual
2020-08-18 9:13 ` Jonathan Cameron
2020-08-18 9:41 ` Anshuman Khandual
2020-08-18 12:26 ` Jonathan Cameron [this message]
2020-08-19 9:10 ` Anshuman Khandual
2020-09-03 16:56 ` Catalin Marinas
2020-09-03 17:31 ` Ralph Campbell
2020-09-08 10:25 ` Anshuman Khandual
2020-09-08 10:18 ` Anshuman Khandual
2020-09-08 11:32 ` Catalin Marinas
2020-08-17 9:19 ` [PATCH 2/2] arm64/mm: Enable THP migration Anshuman Khandual
2020-09-03 16:58 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818132625.00003d05@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).