From: Greg KH <gregkh@linuxfoundation.org>
To: Mohammed Rushad <mohammedrushad@gmail.com>
Cc: vkor@vkten.in, hdegoede@redhat.com, Larry.Finger@lwfinger.net,
john.oldman@polehill.co.uk, yanaijie@huawei.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: fix coding style issue in xmit_linux.c
Date: Tue, 18 Aug 2020 16:04:44 +0200 [thread overview]
Message-ID: <20200818140444.GB547677@kroah.com> (raw)
In-Reply-To: <20200802185644.19674-1-mohammedrushad@gmail.com>
On Mon, Aug 03, 2020 at 12:26:44AM +0530, Mohammed Rushad wrote:
> This is a patch to the xmit_linux.c file that fixes brace and missing
> line warning found by checkpatch.pl tool
>
> Signed-off-by: Mohammed Rushad <mohammedrushad@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> index fec8a8caaa46..b199d355e568 100644
> --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> @@ -148,13 +148,13 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
> /* free sta asoc_queue */
> while (phead != plist) {
> int stainfo_offset;
> +
> psta = LIST_CONTAINOR(plist, struct sta_info, asoc_list);
> plist = get_next(plist);
>
> stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
> - if (stainfo_offset_valid(stainfo_offset)) {
> + if (stainfo_offset_valid(stainfo_offset))
> chk_alive_list[chk_alive_num++] = stainfo_offset;
> - }
> }
> spin_unlock_bh(&pstapriv->asoc_list_lock);
>
As trivial as it is, this is still two different things in a single
patch :(
If this was the last remaining issue in this file, I might consider it,
but it isn't, so please break up your changes into
one-type-of-change-per-patch.
thanks,
greg k-h
prev parent reply other threads:[~2020-08-18 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 18:56 [PATCH] staging: rtl8723bs: os_dep: fix coding style issue in xmit_linux.c Mohammed Rushad
2020-08-18 14:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818140444.GB547677@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=hdegoede@redhat.com \
--cc=john.oldman@polehill.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mohammedrushad@gmail.com \
--cc=vkor@vkten.in \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).