Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards

From: Greg KH <gregkh@linuxfoundation.org>
To: Vaishnav M A <vaishnav@beagleboard.org>
Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, johan@kernel.org, elder@kernel.org,
	robh@kernel.org, mchehab+huawei@kernel.org, davem@davemloft.net,
	"Jason Kridner" <jkridner@beagleboard.org>,
	"Drew Fustini" <drew@beagleboard.org>,
	"Robert Nelson" <robertcnelson@beagleboard.org>,
	"Ivan Rajković" <rajkovic@mikroe.com>,
	chrisfriedt@gmail.com, zoran.stojsavljevic@gmail.com
Subject: Re: [RFC PATCH v2 0/3] mikroBUS driver for add-on boards
Date: Wed, 19 Aug 2020 07:54:27 +0200	[thread overview]
Message-ID: <20200819055427.GB853200@kroah.com> (raw)
In-Reply-To: <CALudOK4jgtJiB8sn4CsDm2c=va=d8M7ocoa55f=NV9sTaBHJJg@mail.gmail.com>

On Wed, Aug 19, 2020 at 03:22:48AM +0530, Vaishnav M A wrote:
> On Tue, Aug 18, 2020 at 8:54 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Aug 18, 2020 at 06:18:12PM +0530, Vaishnav M A wrote:
> > > Hi,
> > >
> > > This Patch series is an update to the mikroBUS driver
> > > RFC v1 Patch : https://lkml.org/lkml/2020/7/24/518 .
> >
> > Please use lore.kernel.org for links, we have no idea if lkml.org will
> > be working tomorrow or not :)
> >
> Hi Greg,
> 
> Thanks, will use lore.kernel.org for the links, attaching the corresponding
> link to the v1 RFC patch thread for reference:
> https://lore.kernel.org/lkml/20200724120637.GA427284@vaishnav-VirtualBox/
> 
> > > The mikrobus driver is updated to add mikrobus ports from device-tree
> > > overlays, the debug interfaces for adding mikrobus ports through sysFS
> > > is removed, and the driver considers the extended usage of mikrobus
> > > port pins from their standard purposes.
> >
> > I don't know what "properties" and "device" mean with regards to things
> > here, any chance you can provide a patch to the greybus spec itself that
> > adds this information so we can better understand the reasoning here to
> > see if the kernel changes match up with the goals?
> >
> > thanks,
> >
> > greg k-h
> Sure, I will add a patch to the greybus-spec to describe the new descriptors,
> the property and device descriptors are introduced to add information
> about the SPI/I2C/UART chip/sensor which is required by the corresponding
> device drivers, With these descriptors, it will be possible to describe devices
> on I2C, SPI, UART, etc. behind a greybus device so as to bind existing kernel
> drivers to them, This is not what is currently being done within the mikroBUS
> driver, now it tries to instantiate devices on actual I2C, SPI, UART from
> describing manifests, but the ultimate goal is to describe the devices on
> I2C/SPI/UART behind a greybus device, thus enabling to attach existing
> kernel drivers to devices present in add-on boards attached to mikroBUS
> ports added via greybus.
> 
> Shall I submit a pull request to https://github.com/projectara/greybus-spec
> for the specs, is there a different official upstream to greybus-spec?

That's a good place, but for now, you can submit it as part of your
patch series as well, so we can all see it and review it easier.

thanks,

greg k-h