From: Leon Romanovsky <leon@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Jeff Layton <jlayton@kernel.org>,
Ceph Development <ceph-devel@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ceph: Delete features that are not used in the kernel
Date: Wed, 19 Aug 2020 12:40:37 +0300 [thread overview]
Message-ID: <20200819094037.GT7555@unreal> (raw)
In-Reply-To: <CAOi1vP-54DybxncMy0tyyy62nsgvQEn0DysbOTpmk_tnxnbv-g@mail.gmail.com>
On Wed, Aug 19, 2020 at 10:47:38AM +0200, Ilya Dryomov wrote:
> On Wed, Aug 19, 2020 at 9:57 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > The ceph_features.h has declaration of features that are not in-use
> > in kernel code. This causes to seeing such compilation warnings in
> > almost every kernel compilation.
> >
> > ./include/linux/ceph/ceph_features.h:14:24: warning: 'CEPH_FEATURE_UID' defined but not used [-Wunused-const-variable=]
> > 14 | static const uint64_t CEPH_FEATURE_##name = (1ULL<<bit); \
> > | ^~~~~~~~~~~~~
> > ./include/linux/ceph/ceph_features.h:75:1: note: in expansion of macro 'DEFINE_CEPH_FEATURE'
> > 75 | DEFINE_CEPH_FEATURE( 0, 1, UID)
> > | ^~~~~~~~~~~~~~~~~~~
> >
> > The upstream kernel indeed doesn't have any use of them, so delete it.
> >
> > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> > ---
> > I'm sending this as RFC because probably the patch is wrong, but I
> > would like to bring your attention to the existing problem and asking
> > for an acceptable solution.
>
> Hi Leon,
>
> Yes, removing unused feature definitions is wrong. Annotating them
> as potentially unused would be much better -- I'll send a patch.
>
> I don't think any of us builds with W=1, so these things don't get
> noticed.
Thanks, W=1 is our default compilation level for Mellanox RDMA submissions.
>
> Thanks,
>
> Ilya
prev parent reply other threads:[~2020-08-19 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 7:57 [RFC PATCH] ceph: Delete features that are not used in the kernel Leon Romanovsky
2020-08-19 8:47 ` Ilya Dryomov
2020-08-19 9:40 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819094037.GT7555@unreal \
--to=leon@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).