[PATCH] irqchip: ingenic: Leave parent IRQ unmasked on suspend

[PATCH] irqchip: ingenic: Leave parent IRQ unmasked on suspend

[Paul Cercueil]

All the wakeup sources we possibly want will go through the interrupt
controller, so the parent IRQ must not be masked during suspend, or
there won't be any way to wake up the system.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 drivers/irqchip/irq-ingenic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c
index 9f3da4260ca6..b61a8901ef72 100644
--- a/drivers/irqchip/irq-ingenic.c
+++ b/drivers/irqchip/irq-ingenic.c
@@ -125,7 +125,7 @@ static int __init ingenic_intc_of_init(struct device_node *node,
 		irq_reg_writel(gc, IRQ_MSK(32), JZ_REG_INTC_SET_MASK);
 	}
 
-	if (request_irq(parent_irq, intc_cascade, 0,
+	if (request_irq(parent_irq, intc_cascade, IRQF_NO_SUSPEND,
 			"SoC intc cascade interrupt", NULL))
 		pr_err("Failed to register SoC intc cascade interrupt\n");
 	return 0;
-- 
2.28.0

Re: [PATCH] irqchip: ingenic: Leave parent IRQ unmasked on suspend

[Marc Zyngier]

On 2020-08-19 19:06, Paul Cercueil wrote:
> All the wakeup sources we possibly want will go through the interrupt
> controller, so the parent IRQ must not be masked during suspend, or
> there won't be any way to wake up the system.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

Do you have a Fixes: tag? Does it need to be Cc: to stable?

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH] irqchip: ingenic: Leave parent IRQ unmasked on suspend

[Paul Cercueil]

Hi Marc,

Le jeu. 20 août 2020 à 9:08, Marc Zyngier <maz@kernel.org> a écrit :
> On 2020-08-19 19:06, Paul Cercueil wrote:
>> All the wakeup sources we possibly want will go through the interrupt
>> controller, so the parent IRQ must not be masked during suspend, or
>> there won't be any way to wake up the system.
>> 
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> 
> Do you have a Fixes: tag? Does it need to be Cc: to stable?

The driver never had it since its creation, so I'm not sure it needs a 
Fixes: tag.

Cheers,
-Paul

> Thanks,
> 
>         M.
> --
> Jazz is not dead. It just smells funny...

[tip: irq/urgent] irqchip/ingenic: Leave parent IRQ unmasked on suspend

[tip-bot2 for Paul Cercueil]

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     821fc9e261f3af235752f46e59084467cfd440c4
Gitweb:        https://git.kernel.org/tip/821fc9e261f3af235752f46e59084467cfd440c4
Author:        Paul Cercueil <paul@crapouillou.net>
AuthorDate:    Wed, 19 Aug 2020 20:06:02 +02:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Tue, 25 Aug 2020 10:59:29 +01:00

irqchip/ingenic: Leave parent IRQ unmasked on suspend

All the wakeup sources we possibly want will go through the interrupt
controller, so the parent IRQ must not be masked during suspend, or
there won't be any way to wake up the system.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200819180602.136969-1-paul@crapouillou.net
---
 drivers/irqchip/irq-ingenic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c
index 9f3da42..b61a890 100644
--- a/drivers/irqchip/irq-ingenic.c
+++ b/drivers/irqchip/irq-ingenic.c
@@ -125,7 +125,7 @@ static int __init ingenic_intc_of_init(struct device_node *node,
 		irq_reg_writel(gc, IRQ_MSK(32), JZ_REG_INTC_SET_MASK);
 	}
 
-	if (request_irq(parent_irq, intc_cascade, 0,
+	if (request_irq(parent_irq, intc_cascade, IRQF_NO_SUSPEND,
 			"SoC intc cascade interrupt", NULL))
 		pr_err("Failed to register SoC intc cascade interrupt\n");
 	return 0;