From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9227FC433E1 for ; Wed, 19 Aug 2020 19:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5918B207BB for ; Wed, 19 Aug 2020 19:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yBsyuDXs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgHSTWG (ORCPT ); Wed, 19 Aug 2020 15:22:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgHSTWD (ORCPT ); Wed, 19 Aug 2020 15:22:03 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FA1DC061757 for ; Wed, 19 Aug 2020 12:22:03 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id 2so1546808pjx.5 for ; Wed, 19 Aug 2020 12:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8PkIiecMhmu/CfXlzNYOVI+vIHq/acMmq5ED/98dBs4=; b=yBsyuDXs/lDr+j83bJq+Tj0dPIqLlnIDJS46d3oNuul7H8WtviWHS92HKFDnoG/24M M+YnJWlPOvojGxb6I3MgqXdAtrhr9KpR96JZy5lPzbDSlf8c5H+I8EsJJpVQOgnaxXgJ keJhv5lWrXztVQIIRqEU3EunvyZjoW9itHkykB8bZz11iyYleCbQEu1a7o4qiOT6ilSy y2iPDoi7FFl4jkkdbTtrYzslFktygRRFI1JwBnLNv6G9XqTlSJsr4ZWSmZ6OFG0DSTvi uwHRh97NxMkRVGfaARTPtZJRxrZfY+RYLmZxBdmMuGCwQ/VMUXebZiMgpESxYZBw15jP Uy+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8PkIiecMhmu/CfXlzNYOVI+vIHq/acMmq5ED/98dBs4=; b=tPlhQBJgBPsUxpgiS2azh3cLt8WMXYxc1cEIzM434a35hmFvqhHfCCmSGfDCq2K3oA 0za4ovsjK6F1C9ks1BcAxRENVqneR2caX3E/QYVgpr+A4kBJj57d3kOusa1kXC8TlVLA a85jzM35GMUKCqLG5qTwoWYs5xqxRZSMrXYFfZJjuIidjtvIV81fGYcA+PxF2gd58xTi Y4WKNxqhBsBUOhfvQh7hYokVbisxsYTvenRVLzcGJ/K7Y0JNPkCcwGGW2P+mLG1mZ5Im lhtHBTlesRi8M6LCtW+Xs1Mj45/1KZFbYcdmoOS6INktJPXqMX9S2SmjRSTlmA8ScDPp /2qg== X-Gm-Message-State: AOAM533IIjMkUE1OhpyHz71AgO3YD8rtsP2SY4oF8/skPrWm+EC/ZMzL AgY3snAaTxa8lIvhSVr9mXlNvw== X-Google-Smtp-Source: ABdhPJy7l97fdQMFvLve4E/Ol0cGTb5PtJ8RsNubKsBb+X1PDsmHlLakGiJ7zMEYWUhK2PH9mls5Xg== X-Received: by 2002:a17:902:bcc6:: with SMTP id o6mr20097915pls.109.1597864922627; Wed, 19 Aug 2020 12:22:02 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id v77sm30508041pfc.137.2020.08.19.12.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 12:22:01 -0700 (PDT) Date: Wed, 19 Aug 2020 13:22:00 -0600 From: Mathieu Poirier To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, coresight@lists.linaro.org, Mike Leach Subject: Re: [PATCH] coresight: etm4x: Handle unreachable sink in perf mode Message-ID: <20200819192200.GA3845366@xps15> References: <20200818192931.168584-1-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818192931.168584-1-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, On Tue, Aug 18, 2020 at 08:29:31PM +0100, Suzuki K Poulose wrote: > If the specified/hinted sink is not reachable from a subset of the CPUs, > we could end up unable to trace the event on those CPUs. This > is the best effort we could do until we support 1:1 configurations. > Fail gracefully in such cases avoiding a WARN_ON, which can be easily > triggered by the user on certain platforms, like : > > [10919.513250] ------------[ cut here ]------------ > [10919.517861] WARNING: CPU: 2 PID: 24021 at > drivers/hwtracing/coresight/coresight-etm-perf.c:316 etm_event_start+0xf8/0x100 > ... > > [10919.564403] CPU: 2 PID: 24021 Comm: perf Not tainted 5.8.0+ #24 > [10919.570308] pstate: 80400089 (Nzcv daIf +PAN -UAO BTYPE=--) > [10919.575865] pc : etm_event_start+0xf8/0x100 > [10919.580034] lr : etm_event_start+0x80/0x100 > [10919.584202] sp : fffffe001932f940 > [10919.587502] x29: fffffe001932f940 x28: fffffc834995f800 > [10919.592799] x27: 0000000000000000 x26: fffffe0011f3ced0 > [10919.598095] x25: fffffc837fce244c x24: fffffc837fce2448 > [10919.603391] x23: 0000000000000002 x22: fffffc8353529c00 > [10919.608688] x21: fffffc835bb31000 x20: 0000000000000000 > [10919.613984] x19: fffffc837fcdcc70 x18: 0000000000000000 > [10919.619281] x17: 0000000000000000 x16: 0000000000000000 > [10919.624577] x15: 0000000000000000 x14: 00000000000009f8 > [10919.629874] x13: 00000000000009f8 x12: 0000000000000018 > [10919.635170] x11: 0000000000000000 x10: 0000000000000000 > [10919.640467] x9 : fffffe00108cd168 x8 : 0000000000000000 > [10919.645763] x7 : 0000000000000020 x6 : 0000000000000001 > [10919.651059] x5 : 0000000000000002 x4 : 0000000000000001 > [10919.656356] x3 : 0000000000000000 x2 : 0000000000000000 > [10919.661652] x1 : fffffe836eb40000 x0 : 0000000000000000 > [10919.666949] Call trace: > [10919.669382] etm_event_start+0xf8/0x100 > [10919.673203] etm_event_add+0x40/0x60 > [10919.676765] event_sched_in.isra.134+0xcc/0x210 > [10919.681281] merge_sched_in+0xb0/0x2a8 > [10919.685017] visit_groups_merge.constprop.140+0x15c/0x4b8 > [10919.690400] ctx_sched_in+0x15c/0x170 > [10919.694048] perf_event_sched_in+0x6c/0xa0 > [10919.698130] ctx_resched+0x60/0xa0 > [10919.701517] perf_event_exec+0x288/0x2f0 > [10919.705425] begin_new_exec+0x4c8/0xf58 > [10919.709247] load_elf_binary+0x66c/0xf30 > [10919.713155] exec_binprm+0x15c/0x450 > [10919.716716] __do_execve_file+0x508/0x748 > [10919.720711] __arm64_sys_execve+0x40/0x50 > [10919.724707] do_el0_svc+0xf4/0x1b8 > [10919.728095] el0_sync_handler+0xf8/0x124 > [10919.732003] el0_sync+0x140/0x180 > > Fixes: f9d81a657bb8 ("coresight: perf: Allow tracing on hotplugged CPUs") > Reported-by: Jeremy Linton > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index 1a3169e69bb1..9d61a71da96f 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -321,6 +321,16 @@ static void etm_event_start(struct perf_event *event, int flags) > if (!event_data) > goto fail; > > + /* > + * Check if this ETM is allowed to trace, as decided > + * at etm_setup_aux(). This could be due to an unreachable > + * sink from this ETM. We can't do much in this case if > + * the sink was specified or hinted to the driver. For > + * now, simply don't record anything on this ETM. > + */ Can you provide more details on the scenario and the topology of the system? Without either it is hard to wrap my head around the problem to address. Having that information in the changelog would go a long way. I'm sure this is a per-thread scenario because there is more than one CPU per event. I'm also suspecting this is on a system where there is one sink per CPU cluster, and that is not supported. If I am right on both account I am questionning the "Fixes". On a system with N:1 topology the code introduced by f9d81a657bb8 will work in the event a CPU is hotplugged in. The code introduced in this patch is simply to prevent a warn_on() trace from being generated on systems that aren't supported. It should have a "stable" tag. Thanks, Mathieu > + if (!cpumask_test_cpu(cpu, &event_data->mask)) > + goto fail_end_stop; > + > path = etm_event_cpu_path(event_data, cpu); > /* We need a sink, no need to continue without one */ > sink = coresight_get_sink(path); > -- > 2.24.1 >