From: Zhen Lei <thunder.leizhen@huawei.com>
To: Oliver O'Halloran <oohall@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
"Dave Jiang" <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Markus Elfring <Markus.Elfring@web.de>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v3 4/7] libnvdimm: reduce an unnecessary if branch in nd_region_create()
Date: Thu, 20 Aug 2020 10:16:38 +0800 [thread overview]
Message-ID: <20200820021641.3188-5-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20200820021641.3188-1-thunder.leizhen@huawei.com>
if (ndr_desc->flush)
1) nd_region->flush = ndr_desc->flush;
else
2) nd_region->flush = NULL;
When entering the "else" branch, the value of ndr_desc->flush is NULL.
After replaced "NULL" with "ndr_desc->flush" at 2), we will find that
it becomes the same to 1).
So the above code snippet can be reduced to one statement:
nd_region->flush = ndr_desc->flush;
No functional change.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/nvdimm/region_devs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
index ef23119db574663..7cf9c7d857909ce 100644
--- a/drivers/nvdimm/region_devs.c
+++ b/drivers/nvdimm/region_devs.c
@@ -1131,10 +1131,7 @@ static struct nd_region *nd_region_create(struct nvdimm_bus *nvdimm_bus,
nd_region->ndr_size = resource_size(ndr_desc->res);
nd_region->ndr_start = ndr_desc->res->start;
nd_region->align = default_align(nd_region);
- if (ndr_desc->flush)
- nd_region->flush = ndr_desc->flush;
- else
- nd_region->flush = NULL;
+ nd_region->flush = ndr_desc->flush;
nd_device_register(dev);
--
1.8.3
next prev parent reply other threads:[~2020-08-20 2:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 2:16 [PATCH v3 0/7] bugfix and optimize for drivers/nvdimm Zhen Lei
2020-08-20 2:16 ` [PATCH v3 1/7] libnvdimm: fix memory leaks in of_pmem.c Zhen Lei
2020-08-20 2:16 ` [PATCH v3 2/7] libnvdimm: add sanity check for provider_name in of_pmem_region_probe() Zhen Lei
2020-08-20 2:16 ` [PATCH v3 3/7] libnvdimm: simplify walk_to_nvdimm_bus() Zhen Lei
2020-08-20 2:16 ` Zhen Lei [this message]
2020-08-20 2:16 ` [PATCH v3 5/7] libnvdimm: reduce an unnecessary if branch in nd_region_activate() Zhen Lei
2020-08-27 7:04 ` Leizhen (ThunderTown)
2020-08-20 2:16 ` [PATCH v3 6/7] libnvdimm: make sure EXPORT_SYMBOL_GPL(nvdimm_flush) close to its function Zhen Lei
2020-08-20 11:05 ` Pankaj Gupta
2020-08-20 2:16 ` [PATCH v3 7/7] libnvdimm: slightly simplify available_slots_show() Zhen Lei
2020-08-27 6:35 ` [PATCH v3 0/7] bugfix and optimize for drivers/nvdimm Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820021641.3188-5-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=oohall@gmail.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).