From: Christoph Hellwig <hch@lst.de>
To: David Fugate <david.fugate@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
Kanchan Joshi <joshi.k@samsung.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
SelvaKumar S <selvakuma.s1@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Subject: Re: [PATCH 2/2] nvme: add emulation for zone-append
Date: Thu, 20 Aug 2020 07:29:21 +0200 [thread overview]
Message-ID: <20200820052921.GA5391@lst.de> (raw)
In-Reply-To: <b52854fe11640a5a5f54e08b1d3c7a556f97aad5.camel@linux.intel.com>
On Wed, Aug 19, 2020 at 01:11:58PM -0600, David Fugate wrote:
> On Tue, 2020-08-18 at 07:12 +0000, Christoph Hellwig wrote:
> > On Tue, Aug 18, 2020 at 10:59:36AM +0530, Kanchan Joshi wrote:
> > > If drive does not support zone-append natively, enable emulation
> > > using
> > > regular write.
> > > Make emulated zone-append cmd write-lock the zone, preventing
> > > concurrent append/write on the same zone.
> >
> > I really don't think we should add this. ZNS and the Linux support
> > were all designed with Zone Append in mind, and then your company did
> > the nastiest possible move violating the normal NVMe procedures to
> > make
> > it optional. But that doesn't change the fact the Linux should keep
> > requiring it, especially with the amount of code added here and how
> > it
> > hooks in the fast path.
>
> Intel does not support making *optional* NVMe spec features *required*
> by the NVMe driver.
That is a great demand, but please stop talking of companies here,
because companies simply don't matter for Linux development. People
and use cases do, companies don't and your mail talking about companies
really can't be taken serious.
And I'm not sure why you think Linux is different from any other NVMe
host OS. If random NVMe host A decided they need feature X they are
going to require it, because why not. Especially if the developers of
host A helped to drive the development of feature X. I'm pretty sure
with a little background in storage standards you've seen that play out
a lot before. And it is no different here.
prev parent reply other threads:[~2020-08-20 5:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200818053247epcas5p262c5fd7e207dfa5145011c4329cf239d@epcas5p2.samsung.com>
2020-08-18 5:29 ` [PATCH 0/2] enable append-emulation for ZNS Kanchan Joshi
[not found] ` <CGME20200818053252epcas5p4ee61d64bba5f6a131105e40330984f5e@epcas5p4.samsung.com>
2020-08-18 5:29 ` [PATCH 1/2] nvme: set io-scheduler requirement " Kanchan Joshi
2020-08-18 7:11 ` Christoph Hellwig
2020-08-19 9:26 ` Kanchan Joshi
2020-08-19 9:38 ` Damien Le Moal
2020-08-19 10:31 ` Kanchan Joshi
2020-08-19 11:17 ` Damien Le Moal
2020-09-07 7:00 ` Kanchan Joshi
2020-09-07 8:22 ` Damien Le Moal
2020-09-07 11:23 ` Kanchan Joshi
2020-09-07 11:37 ` Damien Le Moal
2020-09-07 11:54 ` Kanchan Joshi
2020-09-07 12:53 ` Damien Le Moal
[not found] ` <CGME20200818053256epcas5p46d0b66b3702192eb6617c8bba334c15f@epcas5p4.samsung.com>
2020-08-18 5:29 ` [PATCH 2/2] nvme: add emulation for zone-append Kanchan Joshi
2020-08-18 7:12 ` Christoph Hellwig
2020-08-18 9:50 ` Javier Gonzalez
2020-08-18 10:51 ` Matias Bjørling
2020-08-18 18:11 ` Javier Gonzalez
2020-08-18 15:50 ` Christoph Hellwig
2020-08-18 18:04 ` Javier Gonzalez
2020-08-19 7:40 ` Christoph Hellwig
2020-08-19 8:33 ` Javier Gonzalez
2020-08-19 9:14 ` Damien Le Moal
2020-08-19 10:43 ` Christoph Hellwig
2020-08-20 6:45 ` Javier Gonzalez
2020-08-19 10:49 ` Christoph Hellwig
2020-08-18 16:58 ` Keith Busch
2020-08-18 17:29 ` Javier Gonzalez
2020-08-18 17:39 ` Keith Busch
2020-08-18 18:13 ` Javier Gonzalez
2020-08-19 19:11 ` David Fugate
2020-08-19 19:25 ` Jens Axboe
2020-08-19 21:54 ` David Fugate
2020-08-19 22:10 ` Keith Busch
2020-08-19 23:43 ` David Fugate
2020-08-20 3:45 ` Keith Busch
2020-08-20 23:26 ` David Fugate
2020-08-20 5:51 ` Christoph Hellwig
2020-08-20 6:37 ` Javier Gonzalez
2020-08-20 6:52 ` Christoph Hellwig
2020-08-20 8:03 ` Javier Gonzalez
2020-08-19 21:42 ` Keith Busch
2020-08-20 7:37 ` Kanchan Joshi
2020-08-20 8:14 ` Javier Gonzalez
2020-08-20 5:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820052921.GA5391@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=david.fugate@linux.intel.com \
--cc=javier.gonz@samsung.com \
--cc=johannes.thumshirn@wdc.com \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=sagi@grimberg.me \
--cc=selvakuma.s1@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).