From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A480C433DF for ; Thu, 20 Aug 2020 06:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 720BD208A9 for ; Thu, 20 Aug 2020 06:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597905643; bh=smEfryQX4LpVGJzthIRWac0/v0EWxUcxXXFygmlh3ss=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=S/q7sKve+Yw2P6WYKk+gYHyff9QVjOzx36kXsjWKyB9ktBu528bRBnH18TeGnV6Jz klaHVmQ+43oKY0iCnvvjkc2h1t1hI/YQcH0d6l3OSqNxq2NPPYjrdcpJr00P5pOjfa PeV9je65Mo3Mha+jCTwCbEBAFC0H00P2zCEpHB/Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbgHTGkm (ORCPT ); Thu, 20 Aug 2020 02:40:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:60414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725778AbgHTGkl (ORCPT ); Thu, 20 Aug 2020 02:40:41 -0400 Received: from coco.lan (ip5f5ad5a3.dynamic.kabel-deutschland.de [95.90.213.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D847220786; Thu, 20 Aug 2020 06:40:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597905640; bh=smEfryQX4LpVGJzthIRWac0/v0EWxUcxXXFygmlh3ss=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uVpRlkTA4U4rKgGuZwZCNYKjnVf9jx9QyQlWzioyqxEFKFORZR+nmJ3A1W5F4jif/ BJYtLKuGsdnPxO5hTUeXwINInbRp8ypXBnFZxS/ysUVhzONji7yUZ2lF5OFSGgTyUY 312IwaWgMhztAUA9bEhtGh6dl9ki8qovoCmm2Kpk= Date: Thu, 20 Aug 2020 08:40:30 +0200 From: Mauro Carvalho Chehab To: Sam Ravnborg Cc: John Stultz , Greg Kroah-Hartman , linuxarm@huawei.com, mauro.chehab@huawei.com, Manivannan Sadhasivam , Daniel Vetter , dri-devel , Bogdan Togorean , Liwei Cai , linux-arm-kernel , Daniel Borkmann , Rob Herring , "David S. Miller" , Xinliang Liu , Neil Armstrong , Wanchun Zheng , driverdevel , BPF Mailing List , Xiubin Zhang , linux-media , Tomi Valkeinen , Jesper Dangaard Brouer , Laurent Pinchart , Xinwei Kong , Alexei Starovoitov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Clark , Laurentiu Palcu , Andrzej Hajda , John Fastabend , Liuyao An , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Wei Xu , Rongrong Zou , Philipp Zabel , Network Development , Sumit Semwal , lkml , Jakub Kicinski , David Airlie , Chen Feng Subject: Re: [PATCH 00/49] DRM driver for Hikey 970 Message-ID: <20200820084030.3663de78@coco.lan> In-Reply-To: <20200819212551.GA114762@ravnborg.org> References: <20200819212551.GA114762@ravnborg.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, 19 Aug 2020 23:25:51 +0200 Sam Ravnborg escreveu: > Hi John. > > > > So, IMO, the best is to keep it on staging for a while, until those > > > remaining bugs gets solved. > > > > I'm not sure I see all of these as compelling for pushing it in via > > staging. And I suspect in the process of submitting the patches for > > review folks may find the cause of some of the problems you list here. > > There is a tendency to forget drivers in staging, and with the almost > constant refactoring that happens in the drm drivers we would end up > fixing this driver when a bot trigger an error. > So IMO we need very good reasons to go in via staging. My plan is to have this driver upstream for 5.10, and getting it out of staging by Kernel 5.11. So, I doubt that the DRM kAPIs would change a lot during those 2 Kernel cycles. In any case, I'm also fine to have a final patch at the end of this series moving it out of staging. The only thing that, IMHO, prevents it to be out of staging is the LDI underflow. Right now, if no input events reach the driver, DPMS will put the monitor to suspend, and it never returns back from life. I bet that, once we discover the root cause, the fix would be just a couple of lines, but identifying where the problem is can take a while. Thanks, Mauro