From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5114C433DF for ; Thu, 20 Aug 2020 09:48:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D5E12173E for ; Thu, 20 Aug 2020 09:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597916913; bh=G1CSV8fzdvH/yVrsrPl1vk2V3nEkRTUxsVmgTxVU+yk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LwqKaJ0CF3V4Q4UCsigc/WQCmXVy2eCslUz7mHe0FJks3YKPHpiqBPPEH4s2g7Wjn 9r4LXOVBl+tYAz9MpmWMqX4c+/+Gt8CcUUezAViwo38JJwIKfqaRWQKVDbvGgE0nq6 qWi0++9mvvxzVV50soEPvQe7b2v2Z+QQopNLWlmw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729155AbgHTJsb (ORCPT ); Thu, 20 Aug 2020 05:48:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:52578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729486AbgHTJsH (ORCPT ); Thu, 20 Aug 2020 05:48:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7BC9C20724; Thu, 20 Aug 2020 09:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597916887; bh=G1CSV8fzdvH/yVrsrPl1vk2V3nEkRTUxsVmgTxVU+yk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+Q9ZL9EYzUo1K0qEGgne+S3d2HndaxnpC0NNqlWLLvXP0CfH+s1AYnK91vpTtZJi 99gTNJ9x3x3A810R/idDdNeL7qqH5r/hcQ0HhZyAl2JrujCLtfwW9yZLUxVEjchNBV 2opA8vmPFDGZ+4QUsqwbe1dos9VITREGmzvuujAM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jonathan McDowell , "David S. Miller" Subject: [PATCH 5.4 042/152] net: stmmac: dwmac1000: provide multicast filter fallback Date: Thu, 20 Aug 2020 11:20:09 +0200 Message-Id: <20200820091555.822364614@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091553.615456912@linuxfoundation.org> References: <20200820091553.615456912@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jonathan McDowell commit 592d751c1e174df5ff219946908b005eb48934b3 upstream. If we don't have a hardware multicast filter available then instead of silently failing to listen for the requested ethernet broadcast addresses fall back to receiving all multicast packets, in a similar fashion to other drivers with no multicast filter. Cc: stable@vger.kernel.org Signed-off-by: Jonathan McDowell Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c @@ -166,6 +166,9 @@ static void dwmac1000_set_filter(struct value = GMAC_FRAME_FILTER_PR | GMAC_FRAME_FILTER_PCF; } else if (dev->flags & IFF_ALLMULTI) { value = GMAC_FRAME_FILTER_PM; /* pass all multi */ + } else if (!netdev_mc_empty(dev) && (mcbitslog2 == 0)) { + /* Fall back to all multicast if we've no filter */ + value = GMAC_FRAME_FILTER_PM; } else if (!netdev_mc_empty(dev)) { struct netdev_hw_addr *ha;