LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Mike Marshall <hubcap@omnibond.com>,
	kbuild test robot <lkp@intel.com>
Subject: [PATCH 5.4 075/152] orangefs: get rid of knob code...
Date: Thu, 20 Aug 2020 11:20:42 +0200
Message-ID: <20200820091557.578194646@linuxfoundation.org> (raw)
In-Reply-To: <20200820091553.615456912@linuxfoundation.org>

From: Mike Marshall <hubcap@omnibond.com>

commit ec95f1dedc9c64ac5a8b0bdb7c276936c70fdedd upstream.

Christoph Hellwig sent in a reversion of "orangefs: remember count
when reading." because:

  ->read_iter calls can race with each other and one or
  more ->flush calls. Remove the the scheme to store the read
  count in the file private data as is is completely racy and
  can cause use after free or double free conditions

Christoph's reversion caused Orangefs not to work or to compile. I
added a patch that fixed that, but intel's kbuild test robot pointed
out that sending Christoph's patch followed by my patch upstream, it
would break bisection because of the failure to compile. So I have
combined the reversion plus my patch... here's the commit message
that was in my patch:

  Logically, optimal Orangefs "pages" are 4 megabytes. Reading
  large Orangefs files 4096 bytes at a time is like trying to
  kick a dead whale down the beach. Before Christoph's "Revert
  orangefs: remember count when reading." I tried to give users
  a knob whereby they could, for example, use "count" in
  read(2) or bs with dd(1) to get whatever they considered an
  appropriate amount of bytes at a time from Orangefs and fill
  as many page cache pages as they could at once.

  Without the racy code that Christoph reverted Orangefs won't
  even compile, much less work. So this replaces the logic that
  used the private file data that Christoph reverted with
  a static number of bytes to read from Orangefs.

  I ran tests like the following to determine what a
  reasonable static number of bytes might be:

  dd if=/pvfsmnt/asdf of=/dev/null count=128 bs=4194304
  dd if=/pvfsmnt/asdf of=/dev/null count=256 bs=2097152
  dd if=/pvfsmnt/asdf of=/dev/null count=512 bs=1048576
                            .
                            .
                            .
  dd if=/pvfsmnt/asdf of=/dev/null count=4194304 bs=128

  Reads seem faster using the static number, so my "knob code"
  wasn't just racy, it wasn't even a good idea...

Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/orangefs/file.c            |   26 +-------------------------
 fs/orangefs/inode.c           |   39 ++++++---------------------------------
 fs/orangefs/orangefs-kernel.h |    4 ----
 3 files changed, 7 insertions(+), 62 deletions(-)

--- a/fs/orangefs/file.c
+++ b/fs/orangefs/file.c
@@ -311,23 +311,8 @@ static ssize_t orangefs_file_read_iter(s
     struct iov_iter *iter)
 {
 	int ret;
-	struct orangefs_read_options *ro;
-
 	orangefs_stats.reads++;
 
-	/*
-	 * Remember how they set "count" in read(2) or pread(2) or whatever -
-	 * users can use count as a knob to control orangefs io size and later
-	 * we can try to help them fill as many pages as possible in readpage.
-	 */
-	if (!iocb->ki_filp->private_data) {
-		iocb->ki_filp->private_data = kmalloc(sizeof *ro, GFP_KERNEL);
-		if (!iocb->ki_filp->private_data)
-			return(ENOMEM);
-		ro = iocb->ki_filp->private_data;
-		ro->blksiz = iter->count;
-	}
-
 	down_read(&file_inode(iocb->ki_filp)->i_rwsem);
 	ret = orangefs_revalidate_mapping(file_inode(iocb->ki_filp));
 	if (ret)
@@ -615,12 +600,6 @@ static int orangefs_lock(struct file *fi
 	return rc;
 }
 
-static int orangefs_file_open(struct inode * inode, struct file *file)
-{
-	file->private_data = NULL;
-	return generic_file_open(inode, file);
-}
-
 static int orangefs_flush(struct file *file, fl_owner_t id)
 {
 	/*
@@ -634,9 +613,6 @@ static int orangefs_flush(struct file *f
 	struct inode *inode = file->f_mapping->host;
 	int r;
 
-	kfree(file->private_data);
-	file->private_data = NULL;
-
 	if (inode->i_state & I_DIRTY_TIME) {
 		spin_lock(&inode->i_lock);
 		inode->i_state &= ~I_DIRTY_TIME;
@@ -659,7 +635,7 @@ const struct file_operations orangefs_fi
 	.lock		= orangefs_lock,
 	.unlocked_ioctl	= orangefs_ioctl,
 	.mmap		= orangefs_file_mmap,
-	.open		= orangefs_file_open,
+	.open		= generic_file_open,
 	.flush		= orangefs_flush,
 	.release	= orangefs_file_release,
 	.fsync		= orangefs_fsync,
--- a/fs/orangefs/inode.c
+++ b/fs/orangefs/inode.c
@@ -259,46 +259,19 @@ static int orangefs_readpage(struct file
 	pgoff_t index; /* which page */
 	struct page *next_page;
 	char *kaddr;
-	struct orangefs_read_options *ro = file->private_data;
 	loff_t read_size;
-	loff_t roundedup;
 	int buffer_index = -1; /* orangefs shared memory slot */
 	int slot_index;   /* index into slot */
 	int remaining;
 
 	/*
-	 * If they set some miniscule size for "count" in read(2)
-	 * (for example) then let's try to read a page, or the whole file
-	 * if it is smaller than a page. Once "count" goes over a page
-	 * then lets round up to the highest page size multiple that is
-	 * less than or equal to "count" and do that much orangefs IO and
-	 * try to fill as many pages as we can from it.
-	 *
-	 * "count" should be represented in ro->blksiz.
-	 *
-	 * inode->i_size = file size.
+	 * Get up to this many bytes from Orangefs at a time and try
+	 * to fill them into the page cache at once. Tests with dd made
+	 * this seem like a reasonable static number, if there was
+	 * interest perhaps this number could be made setable through
+	 * sysfs...
 	 */
-	if (ro) {
-		if (ro->blksiz < PAGE_SIZE) {
-			if (inode->i_size < PAGE_SIZE)
-				read_size = inode->i_size;
-			else
-				read_size = PAGE_SIZE;
-		} else {
-			roundedup = ((PAGE_SIZE - 1) & ro->blksiz) ?
-				((ro->blksiz + PAGE_SIZE) & ~(PAGE_SIZE -1)) :
-				ro->blksiz;
-			if (roundedup > inode->i_size)
-				read_size = inode->i_size;
-			else
-				read_size = roundedup;
-
-		}
-	} else {
-		read_size = PAGE_SIZE;
-	}
-	if (!read_size)
-		read_size = PAGE_SIZE;
+	read_size = 524288;
 
 	if (PageDirty(page))
 		orangefs_launder_page(page);
--- a/fs/orangefs/orangefs-kernel.h
+++ b/fs/orangefs/orangefs-kernel.h
@@ -239,10 +239,6 @@ struct orangefs_write_range {
 	kgid_t gid;
 };
 
-struct orangefs_read_options {
-	ssize_t blksiz;
-};
-
 extern struct orangefs_stats orangefs_stats;
 
 /*



  parent reply index

Thread overview: 157+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  9:19 [PATCH 5.4 000/152] 5.4.60-rc1 review Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 001/152] smb3: warn on confusing error scenario with sec=krb5 Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 002/152] genirq/affinity: Make affinity setting if activated opt-in Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 003/152] genirq/PM: Always unlock IRQ descriptor in rearm_wake_irq() Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 004/152] PCI: hotplug: ACPI: Fix context refcounting in acpiphp_grab_context() Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 005/152] PCI: Mark AMD Navi10 GPU rev 0x00 ATS as broken Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 006/152] PCI: Add device even if driver attach failed Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 007/152] PCI: qcom: Define some PARF params needed for ipq8064 SoC Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 008/152] PCI: qcom: Add support for tx term offset for rev 2.1.0 Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 009/152] btrfs: allow use of global block reserve for balance item deletion Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 010/152] btrfs: free anon block device right after subvolume deletion Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 011/152] btrfs: dont allocate anonymous block device for user invisible roots Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 012/152] btrfs: ref-verify: fix memory leak in add_block_entry Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 013/152] btrfs: stop incremening log_batch for the log root tree when syncing log Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 014/152] btrfs: remove no longer needed use of log_writers for the log root tree Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 015/152] btrfs: dont traverse into the seed devices in show_devname Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 016/152] btrfs: open device without device_list_mutex Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 017/152] btrfs: move the chunk_mutex in btrfs_read_chunk_tree Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 018/152] btrfs: relocation: review the call sites which can be interrupted by signal Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 019/152] btrfs: add missing check for nocow and compression inode flags Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 020/152] btrfs: avoid possible signal interruption of btrfs_drop_snapshot() on relocation tree Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 021/152] btrfs: sysfs: use NOFS for device creation Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 022/152] btrfs: dont WARN if we abort a transaction with EROFS Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 023/152] btrfs: fix race between page release and a fast fsync Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 024/152] btrfs: fix messages after changing compression level by remount Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 025/152] btrfs: only search for left_info if there is no right_info in try_merge_free_space Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 026/152] btrfs: inode: fix NULL pointer dereference if inode doesnt need compression Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 027/152] btrfs: fix memory leaks after failure to lookup checksums during inode logging Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 028/152] btrfs: make sure SB_I_VERSION doesnt get unset by remount Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 029/152] btrfs: fix return value mixup in btrfs_get_extent Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 030/152] arm64: perf: Correct the event index in sysfs Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 031/152] dt-bindings: iio: io-channel-mux: Fix compatible string in example code Greg Kroah-Hartman
2020-08-20  9:19 ` [PATCH 5.4 032/152] iio: dac: ad5592r: fix unbalanced mutex unlocks in ad5592r_read_raw() Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 033/152] xtensa: add missing exclusive access state management Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 034/152] xtensa: fix xtensa_pmu_setup prototype Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 035/152] cifs: Fix leak when handling lease break for cached root fid Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 036/152] powerpc/ptdump: Fix build failure in hashpagetable.c Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 037/152] powerpc: Allow 4224 bytes of stack expansion for the signal frame Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 038/152] powerpc: Fix circular dependency between percpu.h and mmu.h Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 039/152] pinctrl: ingenic: Enhance support for IRQ_TYPE_EDGE_BOTH Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 040/152] media: vsp1: dl: Fix NULL pointer dereference on unbind Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 041/152] net: ethernet: stmmac: Disable hardware multicast filter Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 042/152] net: stmmac: dwmac1000: provide multicast filter fallback Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 043/152] net/compat: Add missing sock updates for SCM_RIGHTS Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 044/152] md/raid5: Fix Force reconstruct-write io stuck in degraded raid5 Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 045/152] bcache: allocate meta data pages as compound pages Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 046/152] bcache: fix overflow in offset_to_stripe() Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 047/152] mac80211: fix misplaced while instead of if Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 048/152] driver core: Avoid binding drivers to dead devices Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 049/152] MIPS: CPU#0 is not hotpluggable Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 050/152] MIPS: qi_lb60: Fix routing to audio amplifier Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 051/152] ext2: fix missing percpu_counter_inc Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 052/152] khugepaged: collapse_pte_mapped_thp() flush the right range Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 053/152] khugepaged: collapse_pte_mapped_thp() protect the pmd lock Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 054/152] ocfs2: change slot number type s16 to u16 Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 055/152] mm/page_counter.c: fix protection usage propagation Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 056/152] mm/memory_hotplug: fix unpaired mem_hotplug_begin/done Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 057/152] ftrace: Setup correct FTRACE_FL_REGS flags for module Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 058/152] kprobes: Fix NULL pointer dereference at kprobe_ftrace_handler Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 059/152] tracing/hwlat: Honor the tracing_cpumask Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 060/152] tracing: Use trace_sched_process_free() instead of exit() for pid tracing Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 061/152] tracing: Move pipe reference to trace array instead of current_tracer Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 062/152] watchdog: f71808e_wdt: indicate WDIOF_CARDRESET support in watchdog_info.options Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 063/152] watchdog: f71808e_wdt: remove use of wrong watchdog_info option Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 064/152] watchdog: f71808e_wdt: clear watchdog timeout occurred flag Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 065/152] ceph: set sec_context xattr on symlink creation Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 066/152] ceph: handle zero-length feature mask in session messages Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 067/152] pseries: Fix 64 bit logical memory block panic Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 068/152] module: Correctly truncate sysfs sections output Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 069/152] perf intel-pt: Fix FUP packet state Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 070/152] perf intel-pt: Fix duplicate branch after CBR Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 071/152] remoteproc: qcom: q6v5: Update running state before requesting stop Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 072/152] remoteproc: qcom_q6v5_mss: Validate MBA firmware size before load Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 073/152] remoteproc: qcom_q6v5_mss: Validate modem blob " Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 074/152] drm/imx: imx-ldb: Disable both channels for split mode in enc->disable() Greg Kroah-Hartman
2020-08-20  9:20 ` Greg Kroah-Hartman [this message]
2020-08-20  9:20 ` [PATCH 5.4 076/152] pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 077/152] crypto: algif_aead - Only wake up when ctx->more is zero Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 078/152] mfd: arizona: Ensure 32k clock is put on driver unbind and error Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 079/152] octeontx2-af: change (struct qmem)->entry_sz from u8 to u16 Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 080/152] mtd: rawnand: fsl_upm: Remove unused mtd var Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 081/152] platform/chrome: cros_ec_ishtp: Fix a double-unlock issue Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 082/152] RDMA/ipoib: Return void from ipoib_ib_dev_stop() Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 083/152] RDMA/ipoib: Fix ABBA deadlock with ipoib_reap_ah() Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 084/152] media: rockchip: rga: Introduce color fmt macros and refactor CSC mode logic Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 085/152] media: rockchip: rga: Only set output CSC mode for RGB input Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 086/152] IB/uverbs: Set IOVA on IB MR in uverbs layer Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 087/152] selftests/bpf: Test_progs indicate to shell on non-actions Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 088/152] selftests/bpf: test_progs use another shell exit " Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 089/152] USB: serial: ftdi_sio: make process-packet buffer unsigned Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 090/152] USB: serial: ftdi_sio: clean up receive processing Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 091/152] USB: serial: ftdi_sio: fix break and sysrq handling Greg Kroah-Hartman
2020-08-20  9:20 ` [PATCH 5.4 092/152] crypto: af_alg - Fix regression on empty requests Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 093/152] devres: keep both device name and resource name in pretty name Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 094/152] RDMA/counter: Only bind user QPs in auto mode Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 095/152] RDMA/counter: Allow manually bind QPs with different pids to same counter Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 096/152] mmc: renesas_sdhi_internal_dmac: clean up the code for dma complete Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 097/152] crypto: caam - Remove broken arc4 support Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 098/152] gpu: ipu-v3: image-convert: Combine rotate/no-rotate irq handlers Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 099/152] gpu: ipu-v3: image-convert: Wait for all EOFs before completing a tile Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 100/152] dm rq: dont call blk_mq_queue_stopped() in dm_stop_queue() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 101/152] clk: actions: Fix h_clk for Actions S500 SoC Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 102/152] selftests/powerpc: ptrace-pkey: Rename variables to make it easier to follow code Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 103/152] selftests/powerpc: ptrace-pkey: Update the test to mark an invalid pkey correctly Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 104/152] selftests/powerpc: ptrace-pkey: Dont update expected UAMOR value Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 105/152] iommu/omap: Check for failure of a call to omap_iommu_dump_ctx Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 106/152] clk: qcom: gcc: fix sm8150 GPU and NPU clocks Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 107/152] clk: qcom: clk-alpha-pll: remove unused/incorrect PLL_CAL_VAL Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 108/152] iommu/vt-d: Enforce PASID devTLB field mask Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 109/152] i2c: rcar: slave: only send STOP event when we have been addressed Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 110/152] clk: qcom: gcc-sdm660: Fix up gcc_mss_mnoc_bimc_axi_clk Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 111/152] clk: clk-atlas6: fix return value check in atlas6_clk_init() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 112/152] pwm: bcm-iproc: handle clk_get_rate() return Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 113/152] tools build feature: Use CC and CXX from parent Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 114/152] i2c: rcar: avoid race when unregistering slave Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 115/152] nfs: ensure correct writeback errors are returned on close() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 116/152] ubifs: Fix wrong orphan node deletion in ubifs_jnl_update|rename Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 117/152] clk: bcm2835: Do not use prediv with bcm2711s PLLs Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 118/152] libnvdimm/security: fix a typo Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 119/152] libnvdimm/security: ensure sysfs poll thread woke up and fetch updated attr Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 120/152] openrisc: Fix oops caused when dumping stack Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 121/152] scsi: lpfc: nvmet: Avoid hang / use-after-free again when destroying targetport Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 122/152] nfs: nfs_file_write() should check for writeback errors Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 123/152] watchdog: initialize device before misc_register Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 124/152] md-cluster: Fix potential error pointer dereference in resize_bitmaps() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 125/152] x86/tsr: Fix tsc frequency enumeration bug on Lightning Mountain SoC Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 126/152] Input: sentelic - fix error return when fsp_reg_write fails Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 127/152] recordmcount: Fix build failure on non arm64 Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 128/152] drm/vmwgfx: Use correct vmw_legacy_display_unit pointer Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 129/152] drm/vmwgfx: Fix two list_for_each loop exit tests Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 130/152] net: qcom/emac: add missed clk_disable_unprepare in error path of emac_clks_phase1_init Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 131/152] nfs: Fix getxattr kernel panic and memory overflow Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 132/152] fs/minix: set s_maxbytes correctly Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 133/152] fs/minix: fix block limit check for V1 filesystems Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 134/152] fs/minix: remove expected error message in block_to_path() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 135/152] fs/ufs: avoid potential u32 multiplication overflow Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 136/152] test_kmod: avoid potential double free in trigger_config_run_type() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 137/152] i2c: iproc: fix race between client unreg and isr Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 138/152] mfd: dln2: Run event handler loop under spinlock Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 139/152] crypto: algif_aead - fix uninitialized ctx->init Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 140/152] ALSA: echoaudio: Fix potential Oops in snd_echo_resume() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 141/152] perf bench mem: Always memset source before memcpy Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 142/152] tools build feature: Quote CC and CXX for their arguments Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 143/152] perf/x86/rapl: Fix missing psys sysfs attributes Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 144/152] sh: landisk: Add missing initialization of sh_io_port_base Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 145/152] khugepaged: retract_page_tables() remember to test exit Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 146/152] arm64: dts: marvell: espressobin: add ethernet alias Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 147/152] drm/radeon: fix fb_div check in ni_init_smc_spll_table() Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 148/152] drm/panfrost: Use kvfree() to free bo->sgts Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 149/152] drm: Added orientation quirk for ASUS tablet model T103HAF Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 150/152] drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 151/152] drm/amdgpu: Fix bug where DPM is not enabled after hibernate and resume Greg Kroah-Hartman
2020-08-20  9:21 ` [PATCH 5.4 152/152] drm/amd/display: dchubbub p-state warning during surface planes switch Greg Kroah-Hartman
2020-08-20 17:24 ` [PATCH 5.4 000/152] 5.4.60-rc1 review Naresh Kamboju
2020-08-21 16:33   ` Naresh Kamboju
2020-08-20 20:04 ` Guenter Roeck
2020-08-20 23:49 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820091557.578194646@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=hubcap@omnibond.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git