From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F013C433E1 for ; Thu, 20 Aug 2020 11:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DC142078D for ; Thu, 20 Aug 2020 11:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597922416; bh=77L1bT0czLRh2yTcmUxB1o8+UPyYF+lEMFXijGQaeTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R0OsgQ14cgnCfasB5nh/SFTaAsfAHMcQiDI+xaTeuLf4OyRHV9E6/I4tYcWK/u7UZ Y/NMeh9vLUFLZlC+JFMhjrqLdijjBBnhzH13xieATonYUBCFHlPRfGqunA83XHzKoA sy96J+iFxmjuAx2LJllA+/4NSNY1Pzha6M8qKAZw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730403AbgHTLUL (ORCPT ); Thu, 20 Aug 2020 07:20:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:38210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730677AbgHTKHo (ORCPT ); Thu, 20 Aug 2020 06:07:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0BAC2067C; Thu, 20 Aug 2020 10:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918064; bh=77L1bT0czLRh2yTcmUxB1o8+UPyYF+lEMFXijGQaeTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=12AYGsgzkzltNbMBtd6ptJkoEP08UeFHGoBQvrWwPRlZd95xHBkJA0KpxL0frYksI w9nSOr826KAaFV5Xorv6MPBySiX+F2nRqMP7voRdoWW9GH7UEnth37vtX1sMbMX5K9 aPxUPAtBFmYBEIj9y2e15AH2uOCJKXNLv49QE/AY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rustam Kovhaev , "David S. Miller" , syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com Subject: [PATCH 4.14 040/228] usb: hso: check for return value in hso_serial_common_create() Date: Thu, 20 Aug 2020 11:20:15 +0200 Message-Id: <20200820091609.541493896@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rustam Kovhaev [ Upstream commit e911e99a0770f760377c263bc7bac1b1593c6147 ] in case of an error tty_register_device_attr() returns ERR_PTR(), add IS_ERR() check Reported-and-tested-by: syzbot+67b2bd0e34f952d0321e@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=67b2bd0e34f952d0321e Signed-off-by: Rustam Kovhaev Reviewed-by: Greg Kroah-Hartman Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/hso.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -2272,12 +2272,14 @@ static int hso_serial_common_create(stru minor = get_free_serial_index(); if (minor < 0) - goto exit; + goto exit2; /* register our minor number */ serial->parent->dev = tty_port_register_device_attr(&serial->port, tty_drv, minor, &serial->parent->interface->dev, serial->parent, hso_serial_dev_groups); + if (IS_ERR(serial->parent->dev)) + goto exit2; dev = serial->parent->dev; /* fill in specific data for later use */ @@ -2323,6 +2325,7 @@ static int hso_serial_common_create(stru return 0; exit: hso_serial_tty_unregister(serial); +exit2: hso_serial_common_free(serial); return -1; }