From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52E22C433E1 for ; Thu, 20 Aug 2020 11:06:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DB232072D for ; Thu, 20 Aug 2020 11:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597921566; bh=oz8I1uWJ0oVYI+UQKd++SggARFIdtjlWiOTOgv1IVTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=R2I6nn5Cp1D0KBfsJpXuR9erY6SU6lfCIejk92KeO6zFw/Us4dC02rATOXH+b8v7s Wv7dr4EOhRZ6j8s8BW7AFOxM8PQcOyRjvi4aq3bZrqKLmPRV7BV0IpEpFCqdwWk6oB ILrM+l0BoRK3zeWFL697lZSw66QV4XiXON7BCirg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731034AbgHTKMO (ORCPT ); Thu, 20 Aug 2020 06:12:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731027AbgHTKL6 (ORCPT ); Thu, 20 Aug 2020 06:11:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B37282078D; Thu, 20 Aug 2020 10:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918318; bh=oz8I1uWJ0oVYI+UQKd++SggARFIdtjlWiOTOgv1IVTY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0fbsXhLBoGMR1kf8GRal/29PkeG3IPjGS9L9KJKyyGc3VG0di1N0LcX6ZVXCuuAkW gllEg1w0CI1LCQRGRajcm9j662aXrm9Ml+DCVEK+lUTCkPbUa4fuiqdiI6knHrUcGN hNJwIr160e9EI5QOQQ1Wf2Ng+p4B+n03Nrr0R3fA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rick Farrington , Tianjia Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 128/228] liquidio: Fix wrong return value in cn23xx_get_pf_num() Date: Thu, 20 Aug 2020 11:21:43 +0200 Message-Id: <20200820091613.984792749@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tianjia Zhang [ Upstream commit aa027850a292ea65524b8fab83eb91a124ad362c ] On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a virtual machine") Cc: Rick Farrington Signed-off-by: Tianjia Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c index 2e089b5ff8f32..30f0e54f658e9 100644 --- a/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c +++ b/drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c @@ -1167,7 +1167,7 @@ static int cn23xx_get_pf_num(struct octeon_device *oct) oct->pf_num = ((fdl_bit >> CN23XX_PCIE_SRIOV_FDL_BIT_POS) & CN23XX_PCIE_SRIOV_FDL_MASK); } else { - ret = EINVAL; + ret = -EINVAL; /* Under some virtual environments, extended PCI regs are * inaccessible, in which case the above read will have failed. -- 2.25.1