From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 900BCC433E1 for ; Thu, 20 Aug 2020 10:51:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A62C20724 for ; Thu, 20 Aug 2020 10:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597920667; bh=sYOkpyDBSUPLH/d+kI2y7DYG7MdGLaO75GbP0Y15A78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EHLTGdYxXp4Kb/VG/uLm2WIgkpYPbIdg/DkvCCuOJj7ybb8gMLSRAZVwGv2Lr0ubw oA7uJiU7lO6pC0wKgmV9CH0pwG31TupYnOFicNBoBjU8w1L3J+au8aZLXRL9ECuZRU R82RsbGJZT+NAMPoAvCPJMqKFfXs5Yz+RE/qDJ0k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731211AbgHTKOy (ORCPT ); Thu, 20 Aug 2020 06:14:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:33052 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731181AbgHTKOc (ORCPT ); Thu, 20 Aug 2020 06:14:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DD7B2067C; Thu, 20 Aug 2020 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597918472; bh=sYOkpyDBSUPLH/d+kI2y7DYG7MdGLaO75GbP0Y15A78=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bqv74Q7Cc7F/iRVlRYrsrR0iKrj/gpnZxlaUdxqN6R7OIg955t2la7RTcMxt5bqz0 yo30Dv5IfZRMZnlVVid4BtygqZgujVnfMj4wEhqxXR1hTyQAhQx6mZb/JvdMom/jb1 wWeU2j1C2p53pUA0qHQIYD6fJ6oxdL1osRvIwHTE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ben Greear , Johannes Berg Subject: [PATCH 4.14 181/228] mac80211: fix misplaced while instead of if Date: Thu, 20 Aug 2020 11:22:36 +0200 Message-Id: <20200820091616.623183778@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200820091607.532711107@linuxfoundation.org> References: <20200820091607.532711107@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg commit 5981fe5b0529ba25d95f37d7faa434183ad618c5 upstream. This never was intended to be a 'while' loop, it should've just been an 'if' instead of 'while'. Fix this. I noticed this while applying another patch from Ben that intended to fix a busy loop at this spot. Cc: stable@vger.kernel.org Fixes: b16798f5b907 ("mac80211: mark station unauthorized before key removal") Reported-by: Ben Greear Link: https://lore.kernel.org/r/20200803110209.253009ae41ff.I3522aad099392b31d5cf2dcca34cbac7e5832dde@changeid Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/mac80211/sta_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -952,7 +952,7 @@ static void __sta_info_destroy_part2(str might_sleep(); lockdep_assert_held(&local->sta_mtx); - while (sta->sta_state == IEEE80211_STA_AUTHORIZED) { + if (sta->sta_state == IEEE80211_STA_AUTHORIZED) { ret = sta_info_move_state(sta, IEEE80211_STA_ASSOC); WARN_ON_ONCE(ret); }