LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Marco Elver <elver@google.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
	mingo@kernel.org, will@kernel.org, npiggin@gmail.com,
	jgross@suse.com, paulmck@kernel.org, rjw@rjwysocki.net,
	joel@joelfernandes.org, svens@linux.ibm.com, tglx@linutronix.de
Subject: Re: [PATCH 0/9] TRACE_IRQFLAGS wreckage
Date: Thu, 20 Aug 2020 15:59:23 -0400
Message-ID: <20200820155923.3d5c4873@oasis.local.home> (raw)
In-Reply-To: <20200820172046.GA177701@elver.google.com>

On Thu, 20 Aug 2020 19:20:46 +0200
Marco Elver <elver@google.com> wrote:

> On Thu, Aug 20, 2020 at 04:58PM +0200, peterz@infradead.org wrote:
> > On Thu, Aug 20, 2020 at 10:36:43AM -0400, Steven Rostedt wrote:  
> > > 
> > > I tested this series on top of tip/master and triggered the below
> > > warning when running the irqsoff tracer boot up test (config attached).
> > > 
> > > -- Steve
> > > 
> > >  Testing tracer irqsoff: 
> > >  
> > >  =============================
> > >  WARNING: suspicious RCU usage
> > >  5.9.0-rc1-test+ #92 Not tainted
> > >  -----------------------------
> > >  include/trace/events/lock.h:13 suspicious rcu_dereference_check() usage!  
> ...
> > 
> > Shiny, I think that wants something like the below, but let me go frob
> > my config and test it.
> > 
> > ---
> > --- a/drivers/cpuidle/cpuidle.c
> > +++ b/drivers/cpuidle/cpuidle.c  
> ...
> 
> With that applied (manually, due to conflicts), I still get warnings for
> certain call locations with KCSAN on (that is with my fix from the other
> email):
> 
> | =============================
> | WARNING: suspicious RCU usage
> | 5.9.0-rc1+ #23 Tainted: G        W        
> | -----------------------------
> | include/trace/events/random.h:310 suspicious rcu_dereference_check() usage!
> | 
> | other info that might help us debug this:
> | 
> | 
> | rcu_scheduler_active = 2, debug_locks = 0
> | RCU used illegally from extended quiescent state!
> | no locks held by swapper/1/0.
> | 
> | stack backtrace:
> | CPU: 1 PID: 0 Comm: swapper/1 Tainted: G        W         5.9.0-rc1+ #23
> | Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1 04/01/2014
> | Call Trace:
> |  __dump_stack lib/dump_stack.c:77 [inline]
> |  dump_stack+0xf1/0x14d lib/dump_stack.c:118
> |  trace_prandom_u32 include/trace/events/random.h:310 [inline]
> |  prandom_u32+0x1ee/0x200 lib/random32.c:86
> |  prandom_u32_max include/linux/prandom.h:46 [inline]
> |  reset_kcsan_skip kernel/kcsan/core.c:277 [inline]
> |  kcsan_setup_watchpoint+0x9b/0x600 kernel/kcsan/core.c:424
> |  is_idle_task+0xd/0x20 include/linux/sched.h:1671 		<==== inline, but not noinstr
> |  irqentry_enter+0x17/0x50 kernel/entry/common.c:293 		<==== noinstr function
> 

What happens if you apply the below patch?

-- Steve

diff --git a/lib/random32.c b/lib/random32.c
index 932345323af0..1c5607a411d4 100644
--- a/lib/random32.c
+++ b/lib/random32.c
@@ -83,7 +83,7 @@ u32 prandom_u32(void)
 	u32 res;
 
 	res = prandom_u32_state(state);
-	trace_prandom_u32(res);
+	trace_prandom_u32_rcuidle(res);
 	put_cpu_var(net_rand_state);
 
 	return res;

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  7:30 Peter Zijlstra
2020-08-20  7:30 ` [PATCH 1/9] lockdep: Use raw_cpu_*() for per-cpu variables Peter Zijlstra
2020-08-20 13:54   ` Steven Rostedt
2020-08-20  7:30 ` [PATCH 2/9] sched,idle,rcu: Push rcu_idle deeper into the idle path Peter Zijlstra
2020-08-20 13:58   ` Steven Rostedt
2020-08-20  7:30 ` [PATCH 3/9] cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic Peter Zijlstra
2020-08-20  7:30 ` [PATCH 4/9] cpuidle: Move trace_cpu_idle() into generic code Peter Zijlstra
2020-08-20  7:30 ` [PATCH 5/9] x86/entry: Remove unused THUNKs Peter Zijlstra
2020-08-20  7:30 ` [PATCH 6/9] locking/lockdep: Cleanup Peter Zijlstra
2020-08-20  7:30 ` [PATCH 7/9] nds32: Implement arch_irqs_disabled() Peter Zijlstra
2020-08-20  7:30 ` [PATCH 8/9] lockdep: Only trace IRQ edges Peter Zijlstra
2020-08-20  7:30 ` [PATCH 9/9] lockdep,trace: Expose tracepoints Peter Zijlstra
2020-08-20 14:36 ` [PATCH 0/9] TRACE_IRQFLAGS wreckage Steven Rostedt
2020-08-20 14:39   ` Steven Rostedt
2020-08-20 14:49   ` Marco Elver
2020-08-20 14:58   ` peterz
2020-08-20 16:53     ` Steven Rostedt
2020-08-20 17:20     ` Marco Elver
2020-08-20 19:59       ` Steven Rostedt [this message]
2020-08-21  6:37         ` Marco Elver
2020-08-21  6:54       ` peterz
2020-08-21  7:05         ` Marco Elver
2020-08-27  7:54       ` [tip: sched/urgent] sched: Use __always_inline on is_idle_task() tip-bot2 for Marco Elver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820155923.3d5c4873@oasis.local.home \
    --to=rostedt@goodmis.org \
    --cc=elver@google.com \
    --cc=jgross@suse.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git