From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Ahmed S. Darwish" <a.darwish@linutronix.de>,
Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-kernel@vger.kernel.org
Subject: Re: v5.9-rc1 commit reliably breaks pci nvme detection
Date: Thu, 20 Aug 2020 18:12:14 +0100 [thread overview]
Message-ID: <20200820171214.GA15207@infradead.org> (raw)
In-Reply-To: <83a3d1b6-1eb5-859b-3c5c-287d8d18a99b@kernel.dk>
On Thu, Aug 20, 2020 at 11:10:58AM -0600, Jens Axboe wrote:
> To be fair, I've only heard this one complaint about it, so hopefully it's
> not too widespread. I'm on an x86-64 laptop myself with nvme, and it works
> just fine :-)
The cause for this is the weird NVMe of by ones, where 0 in a field
means 1. So for the overflow to happen you need a controller that
supports USHORT_MAX queue entries. Which don't seem to be all that
common.
next prev parent reply other threads:[~2020-08-20 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 13:50 v5.9-rc1 commit reliably breaks pci nvme detection Ahmed S. Darwish
2020-08-17 15:56 ` Keith Busch
2020-08-17 15:58 ` Jens Axboe
2020-08-20 15:35 ` Jens Axboe
2020-08-20 17:07 ` Ahmed S. Darwish
2020-08-20 17:10 ` Jens Axboe
2020-08-20 17:12 ` Christoph Hellwig [this message]
2020-08-20 17:14 ` Jens Axboe
2020-08-21 7:28 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820171214.GA15207@infradead.org \
--to=hch@infradead.org \
--cc=a.darwish@linutronix.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).