From: Jens Wiklander <jens.wiklander@linaro.org>
To: Jorge Ramirez-Ortiz <jorge@foundries.io>
Cc: sumit.garg@linaro.org, ricardo@foundries.io, mike@foundries.io,
tee-dev@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv9] drivers: optee: allow op-tee to access devices on the i2c bus
Date: Fri, 21 Aug 2020 08:21:21 +0200 [thread overview]
Message-ID: <20200821062121.GA1020247@jade> (raw)
In-Reply-To: <20200814111221.5813-1-jorge@foundries.io>
On Fri, Aug 14, 2020 at 01:12:21PM +0200, Jorge Ramirez-Ortiz wrote:
> Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to
> control this type of cryptographic devices it needs coordinated access
> to the bus, so collisions and RUNTIME_PM dont get in the way.
>
> This trampoline driver allow OP-TEE to access them.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>
> ---
> v9: params return value must be written before optee_msg_to_param is called
> v8: review fixes:
> fix types and add TEEC_ERROR_NOT_SUPPORTED to GP errors
> v7: add support for ten bit i2c slave addressing
> v6: compile out if CONFIG_I2C not enabled
> v5: alphabetic order of includes
> v4: remove unnecessary extra line in optee_msg.h
> v3: use from/to msg param to support all types of memory
> modify OPTEE_MSG_RPC_CMD_I2C_TRANSFER message id
>
> drivers/tee/optee/optee_msg.h | 21 +++++++
> drivers/tee/optee/optee_private.h | 1 +
> drivers/tee/optee/rpc.c | 95 +++++++++++++++++++++++++++++++
> 3 files changed, 117 insertions(+)
Looks good. Did you test this with the recently merged
https://github.com/OP-TEE/optee_os/pull/4033 ?
Cheers,
Jens
next prev parent reply other threads:[~2020-08-21 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 11:12 [PATCHv9] drivers: optee: allow op-tee to access devices on the i2c bus Jorge Ramirez-Ortiz
2020-08-21 6:21 ` Jens Wiklander [this message]
2020-08-21 6:36 ` Jorge Ramirez-Ortiz, Foundries
2020-08-21 10:04 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821062121.GA1020247@jade \
--to=jens.wiklander@linaro.org \
--cc=jorge@foundries.io \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@foundries.io \
--cc=ricardo@foundries.io \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).