From: Mark Brown <broonie@kernel.org>
To: Eddie James <eajames@linux.ibm.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, joel@jms.id.au,
bradleyb@fuzziesquirrel.com, robh+dt@kernel.org, arnd@arndb.de
Subject: Re: [PATCH 4/7] dt-bindings: fsi: fsi2spi: Document new restricted property
Date: Fri, 21 Aug 2020 13:03:36 +0100 [thread overview]
Message-ID: <20200821120336.GE4870@sirena.org.uk> (raw)
In-Reply-To: <b9fbd669-3573-a0c9-18d8-6c0c7926625a@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On Thu, Aug 20, 2020 at 04:07:41PM -0500, Eddie James wrote:
> On 8/20/20 12:14 PM, Mark Brown wrote:
> > On Thu, Aug 20, 2020 at 12:02:25PM -0500, Eddie James wrote:
> > > Add documentation for the "fsi2spi,restricted" property which indicates
> > > a controller shouldn't sequence loops and therefore has a smaller
> > > transfer size.
> > In what situation might someone set this? It sounds like a
> > configuration option rather than a description of the hardware.
> It is a description of the configuration of the hardware. For controllers
> that are configured to be restricted for security purposes, this property
> will be set.
The documentation needs to be a *lot* clearer - users need to be able to
relate this to whatever system configuration this corresponds to. Right
now it says that the controller shouldn't sequence loops but there's no
indication of why this might be.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-21 12:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 17:02 [PATCH 0/7] spi: Fix FSI-attached controller and AT25 drivers Eddie James
2020-08-20 17:02 ` [PATCH 1/7] spi: fsi: Handle 9 to 15 byte transfers lengths Eddie James
2020-08-20 17:02 ` [PATCH 2/7] spi: fsi: Fix clock running too fast Eddie James
2020-08-20 17:12 ` Mark Brown
2020-08-20 21:06 ` Eddie James
2020-08-25 7:10 ` Joel Stanley
2020-08-20 17:02 ` [PATCH 3/7] spi: fsi: Fix use of the bneq+ sequencer instruction Eddie James
2020-08-20 17:02 ` [PATCH 4/7] dt-bindings: fsi: fsi2spi: Document new restricted property Eddie James
2020-08-20 17:14 ` Mark Brown
2020-08-20 21:07 ` Eddie James
2020-08-21 12:03 ` Mark Brown [this message]
2020-09-08 20:44 ` Rob Herring
2020-08-20 17:02 ` [PATCH 5/7] spi: fsi: Implement restricted size for certain controllers Eddie James
2020-08-20 17:19 ` Mark Brown
2020-08-20 17:02 ` [PATCH 6/7] spi: fsi: Check mux status before transfers Eddie James
2020-08-20 17:02 ` [PATCH 7/7] eeprom: at25: Split reads into chunks and cap write size Eddie James
2020-08-20 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821120336.GE4870@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=bradleyb@fuzziesquirrel.com \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).